Repository navigation
In GDALDataset, lazy compute of band min max for cell type - #3162
Merged
Merged
Conversation
Reinstates the lazy declaration of this variable as in https://github.com/geotrellis/geotrellis-gdal/pull/40/files#diff-5e19e2811cf054c87ebc2afd642ebaa3R64 Signed-off-by: Jason T. Brown <[email protected]>
Signed-off-by: Jason T. Brown <[email protected]>
pomadchin
approved these changes
Dec 9, 2019
pomadchin
left a comment
pomadchin
left a comment
Member
There was a problem hiding this comment.
Nice! Thanks for fixing that; merging once CI is happy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Reinstates the lazy declaration of the raster band min max variable as in https://github.com/geotrellis/geotrellis-gdal/pull/40/files#diff-5e19e2811cf054c87ebc2afd642ebaa3R64
That lazy declaration has a subtle role with the by-name min max parameter in
GDALUtils.dataTypeToCellType. If notlazy, then the min-max is computed even though it is only used in one case. This can result in a lot of unnecessary I/O.Checklist
docsguides update, if necessaryNotes
This change is only oriented at improving performance. It should not change any behavior in the computation of the CellType.
Closes #3148