Repository navigation
Conversation
pomadchin
requested changes
Feb 6, 2020
Member
|
Ah, it looks like you also need to sign ECA, could you do it if it is not hard for you? If you have / once you'll have a signed ECA you can sign your commit via |
added 2 commits
February 6, 2020 22:11
Signed-off-by: Christopher Brown <[email protected]>
Signed-off-by: Christopher Brown <[email protected]>
notthatbreezy
force-pushed
the
feature/cmb/remove-duplicate-json-codec
branch
from
February 7, 2020 03:12
c1d17fb to
da5ebc4
Compare
Author
|
@pomadchin Updated PR and signed ECA I also added a commit that removed the |
pomadchin
approved these changes
Feb 7, 2020
Signed-off-by: Christopher Brown <[email protected]>
Author
|
Changelog updated! |
Member
|
@notthatbreezy perfect, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This removes a duplicate codec for
TileLayout- there is already one here and it is really easy to get in a situation where both are available and hit an ambiguous implicit error.Checklist