Repository navigation
Make GDALRasterSource behavior consistent with other RasterSources - #3211
Merged
pomadchin merged 3 commits intoMar 27, 2020
Merged
Conversation
pomadchin
force-pushed
the
fix/rastersources-reoslution
branch
3 times, most recently
from
March 26, 2020 19:48
edd154c to
f059799
Compare
echeipesh
approved these changes
Mar 26, 2020
echeipesh
left a comment
echeipesh
left a comment
Contributor
There was a problem hiding this comment.
LGTM, does this really close the issue for .resolutions being consistent for all instances though?
Member
Author
|
@echeipesh at least |
* GDALRasterSource.resample should take into account the resampleMethod
pomadchin
force-pushed
the
fix/rastersources-reoslution
branch
from
March 26, 2020 20:06
f059799 to
a4530e2
Compare
pomadchin
force-pushed
the
fix/rastersources-reoslution
branch
from
March 26, 2020 22:12
6bf87a2 to
3c9ac7d
Compare
Member
Author
|
Will merge this issue once travis is happy. The further discussion and thoughts that I came up with are here #3210 (comment) |
pomadchin
force-pushed
the
fix/rastersources-reoslution
branch
from
March 26, 2020 22:17
3c9ac7d to
27d5c1f
Compare
pomadchin
force-pushed
the
fix/rastersources-reoslution
branch
from
March 26, 2020 22:19
27d5c1f to
61b0f86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR:
This issues makes
GDALRasterSource,GeoTiffRasterSourceandDEMRasterSourceto behave more consistent.Checklist
Related to #3210
Closes #3212