Repository navigation
Add toString and comments - #3217
Merged
Merged
Conversation
CloudNiner
approved these changes
Apr 1, 2020
CloudNiner
left a comment
CloudNiner
left a comment
Contributor
There was a problem hiding this comment.
Nice smattering of code cleanup and QoL improvements. I know you didn't assign anyone yet but this LGTM
| def convert(targetCellType: TargetCellType): RasterSource = | ||
| GeoTiffReprojectRasterSource(dataPath, crs, resampleTarget, resampleMethod, strategy, targetCellType = Some(targetCellType)) | ||
|
|
||
| override def toString: String = s"GeoTiffReprojectRasterSource(${dataPath.value},$crs,$resampleTarget,$resampleMethod)" |
Contributor
There was a problem hiding this comment.
GeoTiffReprojectRasterSource will have an additional parameter OverviewStrategy in #3200. Should we add that to this method as well?
| } | ||
| } | ||
|
|
||
| override def toString: String = s"GeoTiffResampleRasterSource(${dataPath.value},$resampleTarget,$method)" |
Contributor
There was a problem hiding this comment.
GeoTiffResampleRasterSource will have an additional parameter OverviewStrategy in #3200. Should we add that to this method as well?
pomadchin
reviewed
Apr 1, 2020
| } | ||
|
|
||
| override def hashCode: Int = | ||
| override def hashCode(): Int = |
Member
There was a problem hiding this comment.
Thanks for reminding, I updated the Scala 2.13 migration issue #2893
It is added automatically VS Code and version of this plugin changes frequently
Some subclasses are case classes and thats already fine.
pomadchin
reviewed
Apr 3, 2020
| sudo mv $HOME/downloads/hbase-2.2.3-bin.tar.gz hbase-2.2.3-bin.tar.gz && tar xzf hbase-2.2.3-bin.tar.gz | ||
| sudo rm -f hbase-2.2.3/conf/hbase-site.xml && sudo mv .travis/hbase/hbase-site.xml hbase-2.2.3/conf | ||
| sudo hbase-2.2.3/bin/start-hbase.sh | ||
| if [ ! -f $HOME/downloads/hbase-2.2.4-bin.tar.gz ]; then sudo wget -O $HOME/downloads/hbase-2.2.4-bin.tar.gz http://www-us.apache.org/dist/hbase/2.2.4/hbase-2.2.4-bin.tar.gz; fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some
toStringoverrides to commonly used classes that make the REPL output more readable.Demo