Repository navigation
GDALRasterSource should work consistent with BitCellType and ByteCellType - #3233
Merged
pomadchin merged 3 commits intoApr 23, 2020
Merged
Conversation
pomadchin
force-pushed
the
fix/gdal-bit-byte-celltype
branch
from
April 22, 2020 01:40
e250be5 to
3f21638
Compare
Member
Author
pomadchin
commented
Apr 22, 2020
| ct match { | ||
| case BitCellType => | ||
| println("BitCellType requires a new GDALWarpBindings release") | ||
| // GDALRasterSource(path).cellType shouldBe UByteCellType |
Member
Author
There was a problem hiding this comment.
I'll create a PR that would expose bitsPerSample through GDALWarp bindings.
pomadchin
force-pushed
the
fix/gdal-bit-byte-celltype
branch
from
April 22, 2020 01:44
3f21638 to
02d3d6e
Compare
pomadchin
commented
Apr 22, 2020
pomadchin
commented
Apr 22, 2020
pomadchin
force-pushed
the
fix/gdal-bit-byte-celltype
branch
from
April 22, 2020 02:42
0098528 to
da02ce0
Compare
pomadchin
changed the title
pomadchin
force-pushed
the
fix/gdal-bit-byte-celltype
branch
from
April 22, 2020 20:48
da02ce0 to
5c9254f
Compare
pomadchin
force-pushed
the
fix/gdal-bit-byte-celltype
branch
from
April 22, 2020 20:53
5c9254f to
16d7ee0
Compare
Member
Author
|
To make these tests pass we need to merge #3232 and to file a CQ to merge that PR in. |
pomadchin
force-pushed
the
fix/gdal-bit-byte-celltype
branch
from
April 22, 2020 20:55
16d7ee0 to
f92743a
Compare
pomadchin
commented
Apr 22, 2020
Comment on lines
+293
to
+296
| lazy val bitsPerSample = md.get("NBITS").map(_.toInt) | ||
| /** To handle the [[ByteCellType]] it is possible to fetch information about the sampleFormat from the RasdterBand metadata. **/ | ||
| lazy val signed = md.get("PIXELTYPE").contains("SIGNEDBYTE") |
Member
Author
There was a problem hiding this comment.
That is a correct approach to retrieve the sampleFormat and bitsPerSample.
pomadchin
force-pushed
the
fix/gdal-bit-byte-celltype
branch
3 times, most recently
from
April 22, 2020 21:13
9fa5205 to
2067c86
Compare
…te cellTypes, let's remove this part of the logic
pomadchin
force-pushed
the
fix/gdal-bit-byte-celltype
branch
from
April 22, 2020 21:20
2067c86 to
0ff52a9
Compare
pomadchin
commented
Apr 22, 2020
pomadchin
force-pushed
the
fix/gdal-bit-byte-celltype
branch
from
April 23, 2020 00:42
e73c6e4 to
db83894
Compare
metasim
approved these changes
Apr 23, 2020
| case _ => ByteCellType | ||
| } | ||
| if(!signedByte) noDataValue match { | ||
| case Some(nd) if nd.toInt > 0 && nd <= 255 => UByteUserDefinedNoDataCellType(nd.toByte) |
Member
Author
|
The CQ is still in process, I'll merge it as is, keeping an eye on that outstanding CQ. It is a dependency version up so there should be no problems with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR simplifies GDAL CellType derivation function and adds consistency specs
Checklist
Closes #3232