Skip to content

Remove unused allocation from CroppedTile - #3297

Merged
pomadchin merged 1 commit into
locationtech:masterfrom
kthompson:patch-1
Oct 21, 2020
Merged

pomadchin merged 1 commit into
locationtech:masterfrom
kthompson:patch-1

Conversation

@kthompson

Copy link
Copy Markdown
Contributor

No description provided.

@pomadchin

Copy link
Copy Markdown
Member

Hi @kthompson thanks a lot for fixing that! Won't you mind to check other foreach / map functions in other classes for the same issue?

And also eclipse is unhappy with your ECA, could you please sign your commit via git commit --amend -s ?

@pomadchin

pomadchin commented Oct 21, 2020 •

Copy link
Copy Markdown
Member

Oh, it looks like you used another email for signing ECA, or you can sign it here with a new email: https://www.eclipse.org/legal/ECA.php

@kthompson

Copy link
Copy Markdown
Contributor Author

I am not sure what the issue is with the ECA. I have signed it but for whatever reason it doesnt "pass". I could not find any other locations with a similar issue.

@pomadchin

pomadchin commented Oct 21, 2020 •

Copy link
Copy Markdown
Member

@kthompson oh I see, indeed! I checked ECA manually, looks like a bot problem.

@pomadchin pomadchin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a quick fix!

@pomadchin
pomadchin merged commit 59887e9 into locationtech:master Oct 21, 2020
@kthompson
kthompson deleted the patch-1 branch February 19, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants