Repository navigation
Conversation
jisantuc
changed the title
Member
|
Hey James! Thanks for the PR; we haven't had a chance to look into it though. One minor thing here, could you sign ECA please to make Eclipse license checker happy? After that you'd need to add a sing-off footer into the commit via P.S. P.P.S. gz with your first official PR 🎉 🎉 |
Signed-off-by: James Santucci <[email protected]>
Signed-off-by: James Santucci <[email protected]>
jisantuc
force-pushed
the
feature/js/separate-monoidal-part-of-vt
branch
from
January 4, 2021 15:20
37e82d5 to
e60ff8e
Compare
echeipesh
requested changes
Jan 22, 2021
Signed-off-by: James Santucci <[email protected]>
pomadchin
reviewed
Jan 27, 2021
Signed-off-by: James Santucci <[email protected]>
pomadchin
approved these changes
Jan 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR separates the monoidal part of
StrictLayers -- the separate collections of geometries -- from the... I guess "metadata", you know, the other part.It's useful, e.g., if you're getting geometries from somewhere and trying to combine everything into a vector tile layer. The collections of geometries form a lawful monoid, but
StrictLayeras it's currently implemented does not.Checklist
docsguides update, if necessaryDemo
I would have used this here instead of hand-rolling a special
Monoidfor strict layer for each z/x/y tripleNotes
I'd like to prove this is a lawful monoid with
discipline-- e.g. https://github.com/raster-foundry/raster-foundry/blob/develop/app-backend/datamodel/src/test/scala/ScopeSpec.scala#L126. It's pretty easy, but it would require new testing deps and alsoArbitraryinstances for everything going up the dependency chain from theMVTFeatures, which seems like a lot for what is in practice a very fancyMap[String, Seq[A]].