Skip to content

Fix MosaicRasterSource.tileToLayout behavior - #3338

Merged
pomadchin merged 6 commits into
locationtech:masterfrom
pomadchin:fix/mosasic-rs-tiling
Apr 8, 2021
Merged

pomadchin merged 6 commits into
locationtech:masterfrom
pomadchin:fix/mosasic-rs-tiling

Conversation

@pomadchin

@pomadchin pomadchin commented Feb 16, 2021 •

Copy link
Copy Markdown
Member

Overview

MosaicRasterSource.tileToLayout with more than a single RasterSource leads to incorrect reads.

Checklist

  • ./CHANGELOG.md updated, if necessary. Link to the issue if closed, otherwise the PR.
  • Unit tests added for bug-fix or new feature

Closes #3253

@pomadchin
pomadchin requested a review from echeipesh February 16, 2021 22:39
@pomadchin
pomadchin force-pushed the fix/mosasic-rs-tiling branch from dfbe2a9 to 54dcb3d Compare February 16, 2021 23:00
Comment thread raster/src/main/scala/geotrellis/raster/MosaicRasterSource.scala Outdated
}

// https://github.com/locationtech/geotrellis/issues/3253
it("MosaicRasterSource should be properly tiled to layout") {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of the test, is to prove that the read by extent behaves the same way as the read by keys (by bounds).

@pomadchin
pomadchin force-pushed the fix/mosasic-rs-tiling branch 2 times, most recently from cc4c03f to 159f682 Compare March 10, 2021 00:06
@pomadchin
pomadchin force-pushed the fix/mosasic-rs-tiling branch from 159f682 to 6d956f3 Compare March 10, 2021 00:07
Comment thread layer/src/main/scala/geotrellis/layer/LayoutTileSource.scala Outdated
@pomadchin
pomadchin merged commit e6e7cc8 into locationtech:master Apr 8, 2021
@pomadchin
pomadchin deleted the fix/mosasic-rs-tiling branch April 8, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TileToLayout a MosaicRasterSource issue

2 participants