Repository navigation
Make JTSConfig load lazy - #3369
Merged
Merged
Conversation
jisantuc
approved these changes
Apr 1, 2021
jisantuc
left a comment
Contributor
There was a problem hiding this comment.
Tested with local publication in the setting that produced the bug, eeverything's great 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the JTS config loading ordering. That could cause bad JTS factories init, since sometimes the
reference.conffile could be loaded into memory after the call to the config. That could cause following errors:For the context: this could only happen in runs through SBT.
I did a little bit of tracing down the history of this bug and it turned out that it appeared in
1.4.0and all1.4.xversions are affected. However, in1.5.x(checked withRC2) this issue is gone.Checklist