Skip to content

Rework of Integral injection into tile hierarchy (see #3427) - #3432

Closed
metasim wants to merge 1 commit into
locationtech:masterfrom
metasim:bug/integral-boxing
Closed

metasim wants to merge 1 commit into
locationtech:masterfrom
metasim:bug/integral-boxing

Conversation

@metasim

@metasim metasim commented Oct 21, 2021 •

Copy link
Copy Markdown
Member

Overview

Benchmark triggering bug behind #3427, providing framework for fixing and validating performance improvement.

Checklist

  • ./CHANGELOG.md updated, if necessary. Link to the issue if closed, otherwise the PR.
  • [N/A] Module Hierarchy updated, if necessary
  • [N/A] docs guides update, if necessary
  • New user API has useful Scaladoc strings
  • Unit tests added for bug-fix or new feature

Demo

image

Notes

Closes #3427

@metasim
metasim force-pushed the bug/integral-boxing branch from c2c0b0c to 86c624f Compare November 10, 2021 14:38
Removes GridIntegral.
Adds benchmark triggering Integer boxing bug.
@metasim
metasim force-pushed the bug/integral-boxing branch from 6e336fd to 1842aaa Compare November 11, 2021 21:52
@metasim metasim changed the title Benchmark rig for #3427 Rework of Integral injection into tile hierarchy (see #3427) Dec 2, 2021
@pomadchin pomadchin mentioned this pull request Dec 3, 2021
2 tasks done
@metasim

metasim commented Dec 3, 2021

Copy link
Copy Markdown
Member Author

Superseded by #3441

@metasim metasim closed this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ShortUserDefinedNoDataArrayTile.cols()/rows() calls scala/runtime/BoxesRunTime.boxToInteger

1 participant