Skip to content

JTS 1.18, GeoTools 25.0 - #3437

Merged
echeipesh merged 5 commits into
locationtech:masterfrom
echeipesh:jts-1.18
Dec 2, 2021
Merged

echeipesh merged 5 commits into
locationtech:masterfrom
echeipesh:jts-1.18

Conversation

@echeipesh

@echeipesh echeipesh commented Nov 24, 2021 •

Copy link
Copy Markdown
Contributor

Overview

Version bumps to fantastic OverlayNG

Errors in:

  • vector package
  • spark package

CQs:

Checklist

  • ./CHANGELOG.md updated, if necessary. Link to the issue if closed, otherwise the PR.
  • Module Hierarchy updated, if necessary
  • docs guides update, if necessary
  • New user API has useful Scaladoc strings
  • Unit tests added for bug-fix or new feature

Closes #3436

with MultiPointMultiPointDifferenceResult
with MultiPolygonMultiPolygonDifferenceResult
with MultiPointMultiPolygonUnionResult
with MultiPointMultiLineStringUnionResult

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paging @jpolchlo -- seems like JTS got a bit better at simplifying the results of union. I was pretty mechanical about this, could use your 👀 as the vector master.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to look. Got any specific concerns? These Result types are pretty labyrinthine.

@echeipesh echeipesh changed the title JTS 1.18, GeoTools 25, GeoWave 2.0 JTS 1.18, GeoTools 25 Nov 26, 2021
@echeipesh
echeipesh marked this pull request as ready for review November 27, 2021 14:09
@echeipesh echeipesh changed the title JTS 1.18, GeoTools 25 JTS 1.18 Dec 1, 2021
@pomadchin pomadchin changed the title JTS 1.18 JTS 1.18, GeoTools 25.0 Dec 1, 2021
val raster: Raster[T] = Raster(tile, extent)
val result: PolygonalSummaryResult[R] =
raster.polygonalSummary(feature.geom, visitor.getClass.newInstance, options)
raster.polygonalSummary(feature.geom, visitor.getClass.getDeclaredConstructor().newInstance(), options)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@echeipesh what is the difference?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.oracle.com/javase/9/docs/api/java/lang/Class.html#newInstance--

Deprecated. This method propagates any exception thrown by the nullary constructor, including a checked exception. Use of this method effectively bypasses the compile-time exception checking that would otherwise be performed by the compiler. The Constructor.newInstance method avoids this problem by wrapping any exception thrown by the constructor in a (checked) InvocationTargetException.

@pomadchin

Copy link
Copy Markdown
Member

🚀

@echeipesh
echeipesh merged commit 0625997 into locationtech:master Dec 2, 2021
@pomadchin
pomadchin deleted the jts-1.18 branch January 12, 2022 20:12
@pomadchin

Copy link
Copy Markdown
Member

UPD: we don't need PB CQs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants