Repository navigation
Blanket exclude log4j. - #3453
Closed
metasim wants to merge 1 commit into
Closed
Blanket exclude log4j.
#3453metasim wants to merge 1 commit into
metasim wants to merge 1 commit into
Conversation
pomadchin
reviewed
Mar 24, 2022
pomadchin
left a comment
pomadchin
left a comment
Member
There was a problem hiding this comment.
LGTM! But I'm not sure that this change will be reflected in the published packages pom files.
| } | ||
| }, | ||
|
|
||
| excludeDependencies += "log4j" % "log4j", |
Member
There was a problem hiding this comment.
@metasim thx for the PR!
As far as I know, excludeDependencieswould not be reflected in the published artifacts (i.e. see https://repo1.maven.org/maven2/org/locationtech/geotrellis/geotrellis-geotools_2.12/3.6.1/geotrellis-geotools_2.12-3.6.1.pom), could you double check the behavior / switch to using ExclusionRules instead?
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3451