Skip to content

Expose AWS_REQUEST_PAYER environment variable - #3479

Merged
pomadchin merged 3 commits into
locationtech:masterfrom
pomadchin:feature/requester-pays
Jul 27, 2022
Merged

pomadchin merged 3 commits into
locationtech:masterfrom
pomadchin:feature/requester-pays

Conversation

@pomadchin

@pomadchin pomadchin commented Jul 24, 2022 •

Copy link
Copy Markdown
Member

Overview

Closes #3478

Checklist

  • ./CHANGELOG.md updated, if necessary. Link to the issue if closed, otherwise the PR.

@pomadchin
pomadchin force-pushed the feature/requester-pays branch 6 times, most recently from aefe3a0 to d71ab23 Compare July 24, 2022 18:36
@pomadchin pomadchin changed the title Expose AWS S3 RequestPayer env variable Expose AWS_REQUEST_PAYER variable Jul 24, 2022
@pomadchin
pomadchin force-pushed the feature/requester-pays branch from d71ab23 to de655fd Compare July 24, 2022 18:38
@pomadchin
pomadchin force-pushed the feature/requester-pays branch from de655fd to 0fddb30 Compare July 24, 2022 18:38
@pomadchin pomadchin changed the title Expose AWS_REQUEST_PAYER variable Expose AWS_REQUEST_PAYER environment variable Jul 24, 2022
@pomadchin
pomadchin force-pushed the feature/requester-pays branch 2 times, most recently from c68f258 to 261fe03 Compare July 24, 2022 23:11
@pomadchin
pomadchin force-pushed the feature/requester-pays branch from 261fe03 to 9e1779e Compare July 24, 2022 23:17
@pomadchin
pomadchin force-pushed the feature/requester-pays branch from f2ac1cd to eb4f24a Compare July 27, 2022 11:07

@moradology moradology left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and we'll need this to access Landsat on AWS now, it appears. +1

Comment on lines +45 to +50

Try(client.headObject(request))
.map(_ => true)
.recover { case _: NoSuchKeyException => false }
.toEither
.valueOr(throw _)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner.

@pomadchin
pomadchin merged commit 4efd09c into locationtech:master Jul 27, 2022
@pomadchin
pomadchin deleted the feature/requester-pays branch July 27, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWS S3 RequestPayer env variable

2 participants