Repository navigation
Add new kernels - #3486
Merged
Merged
Add new kernels#3486
Conversation
pomadchin
requested changes
Feb 25, 2023
pomadchin
left a comment
pomadchin
left a comment
Member
There was a problem hiding this comment.
Hello! Thanks for a fantastic contribution, and sorry for a very dealyed review.
Could I ask you to adjust tests? So tests actually compare the computed result with some expected values.
pomadchin
force-pushed
the
add_new_kernels
branch
from
September 23, 2023 22:02
e1f3f7d to
c030150
Compare
pomadchin
force-pushed
the
add_new_kernels
branch
from
April 19, 2025 12:33
c030150 to
cf4c3bd
Compare
Closed
pomadchin
force-pushed
the
add_new_kernels
branch
from
April 19, 2025 13:37
0ba0913 to
14785a9
Compare
pomadchin
approved these changes
Apr 19, 2025
pomadchin
left a comment
pomadchin
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution; sorry it took a bit of time to sort it out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add some new kernel for focal calculate.
Checklist