Repository navigation
Increase chances for building feature generation - #752
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts residential building window-decoration generation to produce shutters/sills/balconies more frequently, aligning with the goal of increasing visible feature variety in generated buildings.
Changes:
- Increased shutter placement chance for residential windows.
- Increased window-sill placement chance per floor/window.
- Increased balcony placement chance (still gated to the center window column).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let shutter_roll = | ||
| coord_rng(centre_sum, centre_sum, element.id).random_range(0u32..100); | ||
| if shutter_roll < 12 { | ||
| if shutter_roll < 25 { | ||
| for h in (config.start_y_offset + 1) |
There was a problem hiding this comment.
The shutter spawn probability is encoded as a hard-coded threshold (25 out of 100). Since these rates appear to be tuning knobs, consider extracting this into a named constant (or config field) so future balancing doesn’t require hunting for magic numbers and the intent (% chance) is explicit.
|
⏱️ Benchmark run finished in 0m 26s 📈 Compared against baseline: 30s 🟢 Generation time is unchanged. 📅 Last benchmark: 2026-02-14 17:55:30 UTC You can retrigger the benchmark by commenting |
No description provided.