Repository navigation
Fix minor stuff - #847
Merged
Merged
Fix minor stuff#847
Conversation
…prefix - Package Linux/macOS binaries as .tar.gz in CI to preserve executable permission (fixes "not executable" reports from Mac/Linux users) - Add missing occupied=false block state to all red bed variants so they render correctly in Minecraft Java Edition, and add proper Bedrock bed converter with direction/head_piece_bit/occupied_bit - Remove duplicate "Error!" prefix from download_with_reqwest error return values (emit_gui_error already prepends it)
When the GUI's Minecraft saves directory detection falls back to Desktop, users may not realize where their world was saved. Now opens the file explorer highlighting the generated world folder, using the same show-in-folder mechanism already used for Bedrock .mcworld files.
|
⏱️ Benchmark run finished in 0m 36s 📈 Compared against baseline: 30s 📅 Last benchmark: 2026-03-26 18:04:57 UTC You can retrigger the benchmark by commenting |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on a handful of UX and compatibility tweaks across data retrieval, world generation UX, Bedrock block conversion, and release packaging.
Changes:
- Improves Overpass download error messaging/propagation.
- Adds GUI behavior to reveal the generated Java world folder when output is on the Desktop.
- Extends Bedrock conversion to properly translate Java bed state properties and updates release artifacts to use
.tar.gzon non-Windows for preserved permissions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/retrieve_data.rs |
Refines error strings and returns cleaner error messages from download_with_reqwest. |
src/data_processing.rs |
Emits a GUI event to reveal Java output folders when generated on Desktop. |
src/block_definitions.rs |
Adds default occupied=false to red bed block-state variants. |
src/bedrock_block_map.rs |
Adds bed property conversion (facing/part/occupied) into Bedrock states. |
.github/workflows/release.yml |
Packages non-Windows binaries as .tar.gz and updates macOS universal build + release uploads accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Derive Bedrock bed color from Java block name instead of hardcoding "red", so non-red beds (if added) convert correctly - Update gui_show_in_folder doc comment to reflect it handles both files and directories (not just Bedrock .mcworld) - Add unit tests for bed property conversion (with and without props)
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The event is now used for both Bedrock .mcworld files and Java world directories saved to the Desktop. Rename function, Tauri event, and JS listener to reflect the generic purpose. Also fix misleading comment on the Desktop path check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.