Repository navigation
Auto-gable more building types, add roof synonyms, weeds on dirt - #973
Conversation
OSM taginfo shows ~2% of tagged roofs use shapes (pitched, saltbox, lean_to, side_hipped) that silently fell through to Flat. Map them to their existing closest shape. Extend qualifies_for_auto_gabled_roof so detached/semidetached_house/terrace/bungalow/villa/cabin/hut and farm- building types get a pitched roof by default instead of flat. Add sparse grass/oak-leaf/dead-bush decoration on coarse-dirt patches: in LC_BARE terrain (targeted at COARSE_DIRT specifically, scree stays bare) and on vineyard/brownfield/landfill landuse. Kept rare so the land still reads as arid/disturbed rather than meadow. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
|
⏱️ Benchmark run finished in 0m 58s 📈 Compared against baseline: 30s 🟢 Generation time is unchanged. 📅 Last benchmark: 2026-04-23 18:47:01 UTC You can retrigger the benchmark by commenting |
There was a problem hiding this comment.
Pull request overview
This PR improves realism and tag coverage in world generation by (1) handling common OSM roof-shape synonyms so more buildings get an appropriate non-flat roof, (2) expanding which building types auto-default to pitched roofs when no roof tag is present, and (3) adding sparse “weeds/regrowth” decorations on coarse-dirt surfaces in select bare/landuse contexts.
Changes:
- Map additional
roof:shapevalues/synonyms (e.g.,pitched,saltbox,lean_to,side_hipped) to existing supported roof types instead of falling back to Flat. - Expand
qualifies_for_auto_gabled_roofto include more residential and agricultural building types. - Add rare grass/leaves/dead-bush decoration on coarse dirt in
LC_BAREand invineyard/brownfield/landfilllanduse areas.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/ground_generation.rs |
Adds sparse vegetation placement on coarse-dirt patches within natural bare land-cover, while keeping other bare surfaces mostly undecorated. |
src/element_processing/landuse.rs |
Adds rare weeds/regrowth decoration on coarse-dirt for vineyard/brownfield/landfill landuse areas. |
src/element_processing/buildings.rs |
Extends roof:shape parsing with additional synonyms and broadens auto-gabled eligibility for more building types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
OSM taginfo shows ~2% of tagged roofs use shapes (pitched, saltbox, lean_to, side_hipped) that silently fell through to Flat. Map them to their existing closest shape. Extend qualifies_for_auto_gabled_roof so detached/semidetached_house/terrace/bungalow/villa/cabin/hut and farm- building types get a pitched roof by default instead of flat.
Add sparse grass/oak-leaf/dead-bush decoration on coarse-dirt patches: in LC_BARE terrain (targeted at COARSE_DIRT specifically, scree stays bare) and on vineyard/brownfield/landfill landuse. Kept rare so the land still reads as arid/disturbed rather than meadow.