Repository navigation
Implement From trait for finch - #1
Conversation
|
This is really cool! I think you want just the As an aside (and this probably isn't clear because we don't have any developer docs!), the I'm actually in the middle of a big refactor (that I really need to finish and merge soon; hopefully still this week) to add support for the binary mash format that also cleans up some of our internal code around this. The new implementation of our "generic" sketch struct is: https://github.com/onecodex/finch-rs/blob/binary_support/src/serialization.rs#L33 (the exact commit may be subject to rebase changes, but the |
5895a9d to
922ef18
Compare
|
Now that @bovee I don't have a higher level struct yet (what would be the sourmash signatures or the finch (long story short: |
Trying out the
Fromtrait, andfinchseemed like a good first try (since I can check if the implementations are compatible).pinging @bovee just to make sure I interpreted the
finchstruct correctly: in sourmash we keep the abundance of a k-mer, but finch usescountandextra_count. What is the difference between them, and can I just sum them up to have the total count?The other thing was figuring out what is the k-mer length, since this is not saved in the struct. I solved this by checking the first value from
.into_vec()