data: URLs rejected by latest #1980

Activity

1. haines

   added a commit that references this issue on Jan 6, 2026

   Pin Lychee version

   ...

   d58718d
2. katrinafyi commented on Jan 6, 2026

   

   katrinafyi

   on Jan 6, 2026

   Last edited by katrinafyi

   Member

   More actions

   bisected to f03b1c9 as first bad commit.

   i also note that there is a test dealing with data URIs, but it only tests that the URIs are detected in --dump mode. they don't check whether they are accepted by the link checker.

   after changing TryFrom<&Url> for HostKey to support data URIs, a different error is returned when it gets to
   

   lychee/lychee-lib/src/ratelimit/pool.rs

   Lines 85 to 90 in 03bbbd7

   	let host_key = HostKey::try_from(uri)?;
   	let host = self.get_or_create_host(host_key);
   	host.get_client()
   	.request(method, uri.url.clone())
   	.build()
   	.map_err(ErrorKind::BuildRequestClient)

   
   the request cannot be built for data URIs. i think data URIs shouldn't need to get up to this point, so it should be filtered out earlier in the logic. idk where, though

   👍React with 👍1Reacted by Thomas Zahner
3. thomas-zahner commented on Jan 14, 2026

   

   thomas-zahner

   on Jan 14, 2026

   Member

   More actions

   @haines Thank you very much for reporting. Otherwise this bug would most probably have been shipped with the next release.
4. thomas-zahner

   closed this as completedin #1990on Jan 20, 2026