Skip to content
This repository was archived by the owner on Dec 2, 2025. It is now read-only.
This repository was archived by the owner on Dec 2, 2025. It is now read-only.

LZ4SafeUtils#commonBytes should use Arrays#mismatch #151

Description

@jpountz

When it's ok to start requiring Java 9+ (maybe now is fine since Java 11 is the current LTS release?) we should implement LZ4SafeUtils#commonBytes using Arrays#mismatch. It yielded a good compression speedup on the Lucene implementation of LZ4 compression.

Activity

odaira commented on Oct 31, 2019

@odaira
Member

Good question.... I'll reach out to important consumers of lz4-java. I can think of Kafka, Cassandra, and Spark. Would you remember anything else?

jpountz commented on Nov 7, 2019

@jpountz
CollaboratorAuthor

This sounds like a good start to me!

ijuma commented on Nov 30, 2019

@ijuma

We should consider doing this via MethodHandle when the method is available. Kafka will continue to support Java 8 for a while, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions