…ertion + frontmatterType lang (Phase G) (#4429) * fix(muya): honor frontmatterType when deriving front-matter lang/style `replaceBlockByLabel`'s frontmatter case derived `lang` with `/\+-/.test(frontmatterType)`, a regex that tests for the literal substring '+-' and so never matched any single-char preference value ('-','+',';','{') — `lang` was always 'json'. With the default '-' (YAML) or '+' (TOML) preference, inserting Front Matter round-tripped to JSON `{ ... }` braces instead of `---`/`+++` fences. Replace the buggy regex with a `frontmatterMeta()` helper that maps frontmatterType to lang+style exactly like legacy muyajs `handleFrontMatter` (paragraphCtrl.js): '-' -> yaml/'-', '+' -> toml/'+', ';' -> json/';', '{' -> json/'{'. The serializer switches on `lang`, so this is what makes YAML/TOML emit their fences. Exported for reuse by the document-start insertion path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(muya): updateParagraph 'paragraph' no longer destroys a list/blockquote The Paragraph menu item / `paragraph.paragraph` command sends the 'paragraph' label. Inside a list or blockquote the migrated engine routed it straight to `replaceBlockByLabel` on `_outmostBlockAtCursor()` (the whole container), replacing it with a single paragraph built from only the first content's leading text — every other list item / quote line was silently lost (e.g. `- one\n- two` collapsed to `one`). Legacy muyajs treated 'paragraph' inside a container as a no-op (the cursor's immediate parent is already a paragraph, so paragraphCtrl.js `case 'paragraph'` returned early). Restore that: guard the plain 'paragraph' label so it is a no-op on a list/blockquote container, preserving every item. Leaf blocks (heading, hr, ...) still convert to a paragraph, and `reset-to-paragraph` remains the explicit unwrap command. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(muya): updateParagraph 'front-matter' prepends at document start, idempotent The Paragraph > Front Matter menu item sends the 'front-matter' label. `updateParagraph` had no front-matter case, so it fell through to `replaceBlockByLabel({ block: _outmostBlockAtCursor(), label: 'frontmatter' })`, which REPLACED the block at the cursor with a frontmatter block — destroying that block's content and producing invalid mid-document front matter, with no idempotency guard (repeat invocation duplicated the block). Front matter is only valid as the first block of a document. Add a front-matter branch that mirrors legacy muyajs `handleFrontMatter`: no-op when the document already starts with front matter, otherwise prepend a new frontmatter block at the very top via `_insertFrontMatter()` without touching the cursor block. The block's lang/style follow `frontmatterType` via the shared `frontmatterMeta` helper. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(muya): address PR #4429 review — G4 leaf-only paragraph + G5 quick-insert front matter Two follow-ups from the Copilot review of the Phase G data-loss fixes. G4 (review #1): the `label === 'paragraph'` guard returned early for ANY list/blockquote container, which wrongly suppressed converting a NON-paragraph leaf nested inside the container — e.g. a heading inside a list item stayed a heading. Legacy muyajs (`paragraphCtrl.js case 'paragraph'`) operated on the cursor's immediate leaf (`parent = getParent(block)`) and was a no-op only when that leaf was already a paragraph (`parent.type === 'p'`); otherwise it converted just the leaf. Replace the broad container guard with `_convertLeafToParagraph`, which targets the immediate block at the cursor: no-op when it is already a paragraph, otherwise convert that single leaf in place via `replaceBlockByLabel`. The enclosing list/blockquote is untouched, so the original G4 data loss (collapsing every item/line into one paragraph) stays fixed while a nested heading converts correctly. G5 (review #2): `replaceBlockByLabel`'s `frontmatter` case still did an in-place `block.replaceWith(newBlock)`, so the quick-insert menu ("/Front Matter") could create a frontmatter block MID-document by converting an empty paragraph — but front matter is only valid at document start. The G5 fix had only covered `updateParagraph`. Extract the idempotent doc-start insertion (formerly `Muya._insertFrontMatter`) into a shared `insertFrontMatterAtStart(muya)` helper in config.ts and route BOTH entry points through it: `updateParagraph('front-matter')` and the `frontmatter` label in `replaceBlockByLabel` (which now prepends + returns before the in-place replace). This also closes the keyboard-shortcut quick-insert path, which never consulted `checkCanInsertFrontMatter`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(muya): cover G4 leaf conversion of a heading inside a list item Guards review #1 on PR #4429: `updateParagraph('paragraph')` with the cursor on a heading nested in a list item must convert just that item's heading to a paragraph and leave the 2-item bullet list intact — the earlier "no-op on any list/blockquote container" guard wrongly left the heading unconverted. Asserts the first item became a paragraph, the container is still a 2-item bullet list, both items survive, and the atx hash run is gone. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(muya): cover quick-insert front matter at doc start + frontmatterType '{' Guards reviews #2 and #3 on PR #4429. Review #2 (G5 quick-insert): add a `replaceBlockByLabel({ label: 'frontmatter' })` describe block proving the quick-insert path inserts at document START when triggered mid-document (both original paragraphs survive — the old in-place replace would have destroyed the cursor block), is idempotent when front matter already exists, and honors frontmatterType. Review #3 (G2 '{' case): add the missing frontmatterType '{' coverage — asserts lang 'json' + style '{' serialize the JSON-braces variant (`{ … }`) rather than the `;;;` fences, completing the `-`/`+`/`;`/`{` matrix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Consider the situation when paste Richtext copied from other place #2

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions