Repository navigation
fix: #4356 support custom protocol links - #4416
Phdigital33 wants to merge 1 commit into
Conversation
|
Hi — I came at this issue from the crash side (#4473) and traced the renderer paths while testing, so one heads-up in case it's useful: I believe the new |
|
@Phdigital33 still Draft status? |
|
Thanks @Jocs and @FurkaanBoraa. Yes, this should remain Draft for now. @FurkaanBoraa, I think your read is correct. The current test exercises the main-process IPC path directly, but it does not prove the real editor/popover flow can reach that branch. For custom protocols, Muya appears to sanitize the rendered I'll rework this before marking it ready for review. My plan is to make the actual renderer/Muya path preserve or forward the original link target in a safe way, then replace/augment the direct IPC test with an end-to-end test that starts from a real markdown link, opens the popover, clicks jump, and verifies the expected external-open behavior. I'll also revisit the security boundary around opening custom protocols. If maintainers prefer landing the narrower crash fix first via #4473 and treating custom-protocol support as a separate feature with confirmation/preference behavior, I'm happy to adapt this PR accordingly. |
Closes #4356
Summary
sambesi://...to open through Electron's external shell path.file:,javascript:,data:,vbscript:) out ofopenExternal.C:/Users/example/note.mdas external protocols.href: nulland fall back totextfor links reported by the editor.Type of change
Test plan
Validation run:
Notes:
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.