Skip to content

fix: import removed from export map - #585

Merged
3cp merged 1 commit into
meriyah:mainfrom
timfish:fix/export-map
Jul 24, 2026
Merged

3cp merged 1 commit into
meriyah:mainfrom
timfish:fix/export-map

Conversation

@timfish

@timfish timfish commented Jul 21, 2026 •

Copy link
Copy Markdown
Contributor

6.1.0 dropped the import condition that 5.0.0/6.0.0 had. While module-sync/default still point at the identical file, tools that don't yet recognize module-sync (confirmed: @rollup/plugin-commonjs, and by extension Nitro/Vinxi's standalone-output tracing) silently fail to resolve the package.

I am attempting to fix this in @rollup/plugin-commonjs but including import will fix this for users before the root cause fix trickles down.

@fisker

fisker commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

tools that don't yet recognize module-sync (confirmed: @rollup/plugin-commonjs

Is there an issue link?

@timfish

timfish commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

So far I've opened a Nitro issue with a very minimal reproduction using meriyah:

I haven't reported to Rollup because it might be related to how they use the plugin.

@fisker

fisker commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Thanks, let's see how they repond first.

@timfish

timfish commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

I've narrowed this down to two seperate bugs, one with @vercel/nft and another with nitropack.

Here is the other:

This last one can be worked around via a moduleSyncCatchall setting which just tells nft to include all conditions.

@3cp

3cp commented Jul 23, 2026

Copy link
Copy Markdown
Member

@fisker any downside if we add import? I don't mind it if it helps for bypassing bugs from other tools.

@fisker

fisker commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

any downside if we add import?

There shouldn't be.

@timfish

timfish commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

This would give me great reason to push to upgrade to v7 and drop Node v18 support 🎉

@3cp

3cp commented Jul 24, 2026

Copy link
Copy Markdown
Member

Node 18 was already dropped.

@pkg-pr-new

pkg-pr-new Bot commented Jul 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/meriyah@585

commit: 7a719ce

@3cp
3cp merged commit bcd697e into meriyah:main Jul 24, 2026
6 checks passed
@3cp

3cp commented Jul 24, 2026

Copy link
Copy Markdown
Member

v7.2.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants