Skip to content

Form file paths in an OS agnostic way - #766

Merged
janelletavares merged 1 commit into
masterfrom
os-compatibility
Jun 9, 2023
Merged

janelletavares merged 1 commit into
masterfrom
os-compatibility

Conversation

@janelletavares

@janelletavares janelletavares commented Jun 7, 2023 •

Copy link
Copy Markdown
Contributor

Description of change

Update unit tests, as well, to be able to run them on any OS

Related to https://github.com/meroxa/product/issues/815

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Demo

before after

Additional references

Documentation updated

@janelletavares
janelletavares requested a review from jayjayjpg June 8, 2023 14:12

@jayjayjpg jayjayjpg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great, thank you for the quick update on the unit tests! ✨

@janelletavares
janelletavares merged commit 86f4e38 into master Jun 9, 2023
@janelletavares
janelletavares deleted the os-compatibility branch June 9, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants