Skip to content

dict functions are missing from dynruntime.h #5609

Description

@jeremyherbert

In dynruntime.h, mp_obj_new_dict and mp_obj_dict_store are not defined, whereas mp_obj_new_list and mp_obj_list_append are. Was this deliberate or an oversight?

Activity

  1. dpgeorge commented on Feb 5, 2020

    @dpgeorge
    Member

    It was mostly API functions that were needed by the examples in examples/natmod that were initially added. There's no problem at all to add more API functions.

  2. jeremyherbert commented on Feb 5, 2020

    @jeremyherbert
    ContributorAuthor

    Ok, I will add and PR soon.

  3. added a commit that references this issue on Dec 2, 2021
    1b87d2b
  4. dpgeorge commented on Jun 10, 2022

    @dpgeorge
    Member

    Dict functions were added in 148d122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    py-coreRelates to py/ directory in source

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions