Repository navigation
Failed 'tests/misc/sys_settrace_features.py' #6689
Description
Activity
The .exp for this test is generated by running the file with CPython so the line which has
frame.f_code.co_filename.splitis the culprit indeed. This should do the trick (replace the slashes so the split() works again correctly):"misc" + "".join(frame.f_code.co_filename.replace('\\', '/').split("tests/misc")[-1:]),I patched
tests/misc/sys_settrace_features.pyand did:cd tests py -3 run-tests misc\sys_settrace_features.pyStill fails:
FAIL misc/sys_settrace_features.py 1 tests performed (838 individual testcases) 0 tests passed 1 tests failed: sys_settrace_featuresWrong syntax or wrong patch?
Can you show the diff (i.e. run-tests --print-failures)?
With a
py -3 run-tests --print-failures misc\sys_settrace_features.py, there is no files inresults. So one would assume there are no errors?But a
py -3 run-tests misc\sys_settrace_features.py, gives this huge diff misc_sys_settrace_features.diff.txtHow is this obfuscated script supposed d to work?
Both commandlines shown are the same so not really sure what you mean. The diff still has the exact same problem, which is strange because e.g.
r'miscF:\MingW32\src\Languages\MicroPython\tests\misc\sys_settrace_subdir\trace_generic.py'.replace('\\', '/').split("tests/misc")[-1:]is['/sys_settrace_subdir/trace_generic.py']so it looks as if the patch has no effect; was it applied to the wrong file?How is this obfuscated script supposed d to work?
Which one?
I meant
py -3 run-tests misc\sys_settrace_features.py, give huge diffs.I've applied you diff and reran
cd tests & py -3 ./run-tests. The same diffs on:tests/results/misc_sys_settrace_features.py.expandtests/results/misc_sys_settrace_features.py.out
as before.
And I noted on AppVeyor all these relevant tests are marked
skip(why?):[00:01:01] skip misc/sys_settrace_features.py [00:01:01] skip misc/sys_settrace_generator.py [00:01:01] skip misc/sys_settrace_loop.pyE.g. this one.
So how can you prove your diff works?
And I noted on AppVeyor all these relevant tests are marked skip (why?):
Because settrace isn't enabled by default and the CI builds d not change that - you also had to change code or pass different flags to
maketo have it enabled, right?So how can you prove your diff works?
Here's a build for which I enabled it and where you can see all 3 tests pass both for the msvc and mingw ports: https://ci.appveyor.com/project/stinos/micropython/build/job/4jaq3kg21j8yrsba?fullLog=true (I don't know how long this stays available though)
So obviously something is different for you, but I don't know what and can't really help you. You could start by adding a
print(frame.f_code.co_filename)into sys_settrace_features.py and then work from there to figure out why the path you get there doesn't get the expected treatment. Note you seem to be usingpy -3, not sure if it matters but run-tests defaults to usingpython3.exeunless you explcicitly set the theMICROPY_CPYTHON3environment variable.Does
MICROPY_PY_SYS_SETTRACE0or1has anything to do with this? I fail to see where / howprelude->qstr_source_filegets
set.Sorry now I'm confused: I always assumed you were running a build where you explicitly enabled MICROPY_PY_SYS_SETTRACE, which for the windows ports means e.g. putting this in ports/windows/mpconfigport.h:
#define MICROPY_PERSISTENT_CODE_SAVE (1) #define MICROPY_COMP_CONST (0) #define MICROPY_PY_SYS_SETTRACE (1)If that is not enabled, all related tests should be skipped automatically because the test files start with
try: sys.settrace except AttributeError: print("SKIP") raise SystemExitSo when run with micropython without settrace functionality, this prints SKIP and run-tests picks that up to skip the test.
However from your explanation I now get the impression you didn't enable it explicitly, yet are gettings test failures. No idea how that is even possible.
To figure out what is wrong you'll have to supply enough information so we can get an idea of what you are doing exactly:
- what version fo the code you are using (master branch? which commit?)
- compiler version (I see you have a directory MingW32, note that only ming-w64 is supported)?
- how you build micropython (from which shell, which commands etc)
- if you run micropython and type
import sys.settraceon the command line, what happens?
Off course I have
MICROPY_PY_SYS_SETTRACE=1.Well, the previous comment asked whether MICROPY_PY_SYS_SETTRACE has anything to do with this; to be on the safe side I did not interpret that as 'off course' :)
Anyway: without further info from your side it's going to be hard to fix anything, unless you can figure it out yourself.if you run micropython and type import sys.settrace on the command line, what happens?
MicroPython.exe -c "import sys; sys.settrace(1)" & echo %? 0Trying to simplify this nerdy tool:
cd tests & python3 misc\sys_settrace_features.py > temp.1compared tocd tests & ..\MicroPython.exe misc\sys_settrace_features.py > temp.2
Isn't that how
run-testsbasically does it? With your patch,temp.1andtemp.2are different.Isn't that how run-tests basically does it?
Basically, yes, but perhaps not exactly, and that might matter here. Though if I run those commands (only difference for me being I invoke ..\ports\windows\micropython.exe) I get 2 files which are exactly the same.
I had that one in my PR already, and the diff shown earlier only shows path differences, no zipimport calls, so shouldn't matter here I think.
@stinos I did a
git pull10 min ago and rebuilt everything (for Win32 with lwIP sockets) and re-ran this simple case:cd tests & py -3 misc\sys_settrace_features.py > temp.1 ..\MicroPython.exe misc\sys_settrace_features.py > temp.2 diff -u3 temp.1 temp.2temp.1contains strings like:### trace_handler::main event: call 0: @sys_settrace_subdir.trace_generic:<module> => miscF:\MingW32\src\Languages\MicroPython\tests\misc\sys_settrace_subdir\trace_generic.py:1 1: @__main__:do_tests => misctests\misc\sys_settrace_features.py:106 2: @__main__:<module> => misctests\misc\sys_settrace_features.py:113Seems the
replace()ass-u-mes wrongly. And adding aprint (" co_filename: %s" % frame.f_code.co_filename), I see many:
f:\ProgramFiler\Python36\lib\encodings\cp1252.pyBut I'm utterly confused about what happens here.
I did a git pull 10 min ago
Seeing the differences you have, is it possible you just pulled master? That won't cut it, my PR isn't merged there yet. The code from the PR can be fetched like
git fetch upstream pull/6690/head:pr/6690 git checkout pr/6690where 'upstream' is the name of the MicroPython remote you use.
temp.1 contains strings like:
As mentioned earlier: the equivalent of this code is in the PR
filename = r"F:\MingW32\src\Languages\MicroPython\tests\misc\sys_settrace_subdir\trace_generic.py" print("misc" + "".join(filename.replace("\\", "/").split("tests/misc")[-1:])) # prints misc/sys_settrace_subdir/trace_generic.pyso the most logical explanation would be that this code is not what you are using? How else could you still get the complete filename printed?
I see many: f:\ProgramFiler\Python36\lib\encodings\cp1252.py
Which should also be solved by the PR since it explicitly skips any stack frame with "encodings" in it's name.
I had that one in my PR already,
Ah, indeed, sorry, I missed it!
I'm closing this as this test-command (in my Makefile) works:
cd ./tests ; py -3 ./run-tests misc/sys_settrace_features.py pass misc/sys_settrace_features.py 1 tests performed (838 individual testcases) 1 tests passedBut adding option
--print-failuresas advised gives either no output or indicates a crash:cd ./tests ; py -3 ./run-tests --print-failures misc/sys_settrace_features.py FAILURE F:/MingW32/src/Languages/MicroPython/tests/results\extmod_uselect_poll_basic.py --- F:/MingW32/src/Languages/MicroPython/tests/results/extmod_uselect_poll_basic.py.exp 2020-12-28 11:13:05 +++ F:/MingW32/src/Languages/MicroPython/tests/results/extmod_uselect_poll_basic.py.out 2020-12-28 11:13:05 @@ -1 +1,5 @@ -SKIP +modify:TypeError +Traceback (most recent call last): + File "extmod/uselect_poll_basic.py", line 41, in <module> +OSError: 10038 +CRASH \ No newline at end of file FAILURE F:/MingW32/src/Languages/MicroPython/tests/results\extmod_uselect_poll_udp.py --- F:/MingW32/src/Languages/MicroPython/tests/results/extmod_uselect_poll_udp.py.exp 2020-12-28 11:02:50 +++ F:/MingW32/src/Languages/MicroPython/tests/results/extmod_uselect_poll_udp.py.out 2020-12-28 11:02:50 @@ -1 +1,2 @@ -CPYTHON3 CRASH \ No newline at end of file +0 +TrueNote it runs
extmod/uselect*.pywhen not told to. I fail to understand this junk tool.I fail to understand this junk tool.
Have you considered your failure to understanding is the problem here, not the tool? I politely ignored all your other snarky comments in this thread, but this kind of language is not appreciated here. We want to maintain a nice and friendly environment. And there's plenty of room for criticism and reporting problems, I mean after all it's an issue tracker, but there's no reason to do that in such a disrespectful manner.
- added a commit that references this issue
on Aug 10, 2022
I've built MicroPython on Windows and notice some failures due to mixed expectation of
/vs\in filenames.The diff between:
tests\results\misc_sys_settrace_features.py.expandtests\results\misc_sys_settrace_features.py.outcontains a lot of lines like these:
The line responsible for this difference is AFAICS in
tests\misc\sys_settrace_features.py:"misc" + "".join(frame.f_code.co_filename.split("tests/misc")[-1:]),Where is the cause of these diffs? And how is the
.expfile generated?