ports/rp2: Added init and reset C hooks for RP2040, and increased external pin count - #12283

Could there be a means to include a C header, for hook code that requires it? Or some knack to it?

In my case - for PicoSystem - I might want MICROPY_BOARD_STARTUP to be:

// Apply a modest overvolt, default is 1.10v.
// this is required for a stable 250MHz on some RP2040s
vreg_set_voltage(VREG_VOLTAGE_1_20);
sleep_ms(10);
set_sys_clock_khz(250000, true);

But that depends upon:

#include "hardware/vreg.h

But yeah, +1 to this change, it could benefit PicoSystem and potentially PicoVision.

I think that may already be covered by this addition, as I do

#include "hardware/gpio.h"
#include "hardware/i2c.h"

within my Yukon build. See: https://github.com/pimoroni/yukon/blob/main/firmware/PIMORONI_YUKON/board.c

The functions in this file are hooked in by:

#define MICROPY_BOARD_EARLY_INIT board_init
void board_init(void);

#define MICROPY_BOARD_EARLY_RESET board_reset
void board_reset(void);

Hi. Just wondering if anyone had a chance to look at this yet?

HI @projectgus,

Thank you for taking a look at this.

The max EXT_PINs thing is good to go (I was initially cautious until I realised this only raises the maximum to 32, so doesn't change anything on the current boards!)

Glad to hear it!

For the new C hooks, these are great to have on rp2. My only concern is consistency between ports. See the inline comments for specific thoughts.

I hadn't specifically spotted the STM etc hooks, so apologies for their inconsistency. I will have a look and see what can be changed and respond to your specific notes later.

I will say, I am only actively using the below hooks in the product this PR was primarily raised for.

#define MICROPY_BOARD_EARLY_INIT board_init
#define MICROPY_BOARD_EARLY_RESET board_reset

The others were included to account for possible future use-cases, so I agree they should be consistent.

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS

@ZodiusInfuser Are you still working on this PR? Is there anything you're waiting on from the MicroPython side?

Errr... I'll admit I completely forgot about this open PR after our Pimoroni Yukon was launched 😅. It is still necessary as that product's builds still rely on my rp_init_hooks branch.

Looks like I never addressed your review points before. I'll try and find time this week to look at it, if not it will be after I am back from holiday.

Also tangentially, I noticed in machine_pin_cyw43.c that the opening check assumes that if the network is defined and external pins are set, then those pins come from the cyw43. As micropython does not yet support multiple external pin types (unless things have moved on in the last 9 months?), I believe the following line:

#if defined(MICROPY_PY_NETWORK_CYW43) && defined(MICROPY_HW_PIN_EXT_COUNT)

should be changed to:

#if CYW43_GPIO == 1 && defined(MICROPY_PY_NETWORK_CYW43) && defined(MICROPY_HW_PIN_EXT_COUNT)

to support any future Pico W-based Yukon I may attempt.

Would that be something I could include in this PR, or am I better to raise it as a separate issue / PR?

Would that be something I could include in this PR, or am I better to raise it as a separate issue / PR?

This machine_pin_cyw43.c change looks very reasonable to me, please free to submit it in a separate PR.

This looks good. Thanks for making it more consistent with the stm32 port.

Rebased and merged in 5dfd3ec and 79ba6d8