Repository navigation
esp32: Add bootloader rollback support for all boards. - #12475
Merged
Merged
Conversation
glenn20
force-pushed
the
feature-enable-rollback
branch
from
September 18, 2023 23:21
42f2cd1 to
f18a28d
Compare
Member
|
Shouldn't this be If so, then would be good to remove this same config option from the three existing locations in board config files. |
Contributor
Author
|
Thanks for picking that up Damien. I must have merged the wrong commit from my dev branch. I'll fix, remove from the other OTA sdkconfig files, re-test with the right commits this time and push. |
glenn20
force-pushed
the
feature-enable-rollback
branch
2 times, most recently
from
September 29, 2023 05:32
d552a66 to
b885741
Compare
Contributor
Author
|
Done. Let me know if there are any other issues. It's working for my tests.... |
Add "CONFIG_BOOTLOADER_APP_ROLLBACK_ENABLE=y" to ports/esp32/boards/sdkconfig.base so that all micropython esp32 images support OTA rollback in the bootloader. These images can then be converted to OTA-capable images as required by user tools. Also remove CONFIG_BOOTLOADER_APP_ROLLBACK_ENABLE=y from board-specific sdkconfig files as this is now the default. Signed-off-by: Glenn Moloney <[email protected]>
dpgeorge
force-pushed
the
feature-enable-rollback
branch
from
September 29, 2023 06:02
b885741 to
6662d84
Compare
Member
|
Thanks for updating. Now merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for OTA rollback to the bootloader for all ESP32 builds:
CONFIG_BOOTLOADER_ROLLBACK_ENABLE=ytoports/esp32/boards/sdkconfig.baseso that all micropython esp32 images support OTA rollback in the bootloader.With this change:
There appears to be no detrimental impact arising rom enabling this feature in all ESP32 builds (see Espressif's App Rollback documentation).
This can also eliminate the need to build OTA variants of all esp32 boards for distribution if desired.