docs: Update docs to replace ifconfig with ipconfig. by felixdoerre · Pull Request #14140 · micropython/micropython

felixdoerre · 2024-03-20T20:27:14Z

Follow up for #13689, to update the documentation to refer to ipconfig instead of ifconfig where appropriate.

I've left wipy out, because I couldn't find, which network stack it is using. Also, I am not sure which network stack exactly network.WLAN and network.LAN are referring to. Should I just copy the adjustments form network.rst over to network.WLAN/network.LAN?

dpgeorge · 2024-03-26T06:31:26Z

Thanks for writing these docs, definitely needed!

But, ipconfig() is not yet implemented on esp32 or esp8266 ports. So the docs there shouldn't change. And it means mpremote still needs to use the old ifconfig().

Well, probably it would be better to implement ipconfig() on all the ports first, then we can make a consistent move to that new method, in the docs and everywhere.

dpgeorge · 2024-03-26T06:36:36Z

These are the network interfaces that need ipconfig() added to them:

extmod/network_ninaw10.c
ports/cc3200/mods/modwlan.c
ports/esp32/network_lan.c
ports/esp32/network_ppp.c
ports/esp32/network_wlan.c
ports/esp8266/network_wlan.c
ports/mimxrt/network_lan.c
ports/stm32/network_lan.c

Some of those (eg stm32, mimxrt) are very easy.

robert-hh · 2024-03-26T08:43:10Z

These are the network interfaces that need ipconfig() added to them:

I can start working in these. I have all the boards needed for testing.

felixdoerre · 2024-03-27T12:21:37Z

Yes, @robert-hh, that would be very nice. I have none of these boards :). So I will not touch the networking code for the other ports, that you can do and test the necessary changes.

robert-hh · 2024-03-27T12:37:40Z

@felixdoerre We can also co-operate in that you suggest changes and I will test them.

dpgeorge · 2024-03-27T13:03:34Z

To start with I suggest just implementing the IPv4 config options for ipconfig(), on those additional NICs. That should be relatively straightforward, and would be enough to allow this docs PR to be merged.

robert-hh · 2024-03-27T14:49:44Z

So mimxrt and stm32 were indeed very easy. There others are more work, when they do not use the common LWIP stack. So the ipconfig() method has to be fully implemented, which will take a while. I'm not sure if it's worth the effort for the CC3200 port, since that one is due to be closed.

felixdoerre · 2024-03-27T22:45:43Z

I've started a PR (#14199) to update the configuration function for the other network interfaces. Their current state is also not too consistent. The lwip-variants should all be included in there. I am not sure how consistent we will be able to make the new ipconfig interface.

But, ipconfig() is not yet implemented on esp32 or esp8266 ports. So the docs there shouldn't change. And it means mpremote still needs to use the old ifconfig().

Judging from what is documented (and being a kind-of devil's advocate), we'd only need to implement the esp-netif netconfig for esp32 and esp8266. All the other network interfaces are not documented explicitly anyways, right?

Regarding mpremote: note that this is just a configuration example. If this has ipconfig of ifconfig should not really matter, but I have no strong preference, which one is better.

dpgeorge · 2024-06-04T05:08:36Z

This is being removed because it's documented in the AbstractNIC class, right?

Maybe there needs to be some note in this file that this class does extend the AbstractNIC type and so does have the ifconfig/ipconfig methods.

Yes, also there is also .active, and .status neither are directly documented here and only implicitly inherited. Interestingly the wiznet5k-class does not implement all functions from AbstractNIC (like .scan) but even before the change it implemented more than documented here.

To make it kind-of consistent we could remove the docs for WIZNET5K.isconnected and then add a paragraph linking to AbstractNIC for: isconnected, active, ifconfig (maybe leave that out to encourage ipconfig instead), ipconfig, config and status.

To make it kind-of consistent we could remove the docs for WIZNET5K.isconnected and then add a paragraph linking to AbstractNIC for: isconnected, active, ifconfig (maybe leave that out to encourage ipconfig instead), ipconfig, config and status.

Yes. But that sounds like something for a separate PR.

dpgeorge · 2024-06-04T05:10:59Z

I suggest "(availability of a particular parameter depends on the port and the specific network interface)". Because users see the port/NIC and not so much which compile time flags are enabled.

Looks like this wasn't changed?

ooh yes, I changed the other occurrence. Now I should have both.

felixdoerre · 2024-06-04T07:33:52Z

I think I've incorporated all suggestions and was a bit more thorough to remove ifconfig from the docs as now all nics should have ipconfig.

dpgeorge · 2024-06-04T07:59:36Z

Looks like this wasn't changed?

dpgeorge · 2024-06-04T08:00:56Z

I think this needs more detail on how to set the IPv6 address. Is the thing you set it to a 4 tuple in the same format as returned?

I have an example immediately after the property name, but I'll add it again here. Setting the address as 4-tuple doesn't really make sense. State is not determined by configuration but by duplicate-address-detection and validity is infinite on static addresses by definition.

Follow up to 1c6012b Signed-off-by: Felix Dörre <[email protected]>

dpgeorge · 2024-07-05T06:11:40Z

Thanks for updating, now merged.

With this done we can now officially move forward with using ipconfig() over ifconfig(), and also say we support IPv6 (at least on ports that enable it).

Thanks for all your efforts on this @felixdoerre !

felixdoerre · 2024-07-06T09:28:33Z

So, is it now time to enable ipv6 by default on some ports, e.g. pico-W?

dpgeorge · 2024-07-07T15:53:50Z

So, is it now time to enable ipv6 by default on some ports, e.g. pico-W?

Yes! That would be a good idea. Feel free to make a PR for that, or otherwise I'll eventually get to it.

razvanphp · 2024-09-23T14:40:55Z

Seems like in here, ifconfig is not marked as deprecated and ipconfig is not even mentioned:
https://docs.micropython.org/en/latest/library/network.LAN.html#network.LAN.ifconfig

felixdoerre force-pushed the ipv6_docs branch 2 times, most recently from 79f01be to a8e5c56 Compare March 20, 2024 20:37

robert-hh reviewed Mar 20, 2024

View reviewed changes

Comment thread docs/esp8266/tutorial/network_basics.rst Outdated

felixdoerre force-pushed the ipv6_docs branch from a8e5c56 to 7a900fe Compare March 20, 2024 22:09

dpgeorge added the docs label Mar 25, 2024

dpgeorge added this to the release-1.23.0 milestone Mar 25, 2024

dpgeorge modified the milestones: release-1.23.0, release-1.24.0 Apr 30, 2024

projectgus reviewed May 14, 2024

View reviewed changes

Comment thread docs/library/network.rst Outdated

felixdoerre mentioned this pull request May 18, 2024

Ipv6 support for cyw43/rp2 #9108

Merged

6 of 7 tasks

dpgeorge mentioned this pull request Jun 4, 2024

Add nic.ipconfig for other ports (like esp32, stm32 and others) #14199

Merged

8 tasks done

dpgeorge reviewed Jun 4, 2024

View reviewed changes

felixdoerre force-pushed the ipv6_docs branch from 7a900fe to 9820c68 Compare June 4, 2024 07:32

felixdoerre force-pushed the ipv6_docs branch 2 times, most recently from 635df06 to 8f34cff Compare June 4, 2024 07:42

dpgeorge reviewed Jun 4, 2024

View reviewed changes

felixdoerre force-pushed the ipv6_docs branch from 8f34cff to b62949a Compare June 7, 2024 23:17

felixdoerre force-pushed the ipv6_docs branch 2 times, most recently from 25a80cb to d6b76f3 Compare June 20, 2024 18:34

docs: Update docs to replace ifconfig with ipconfig.

4d16a9c

Follow up to 1c6012b Signed-off-by: Felix Dörre <[email protected]>

dpgeorge force-pushed the ipv6_docs branch from d6b76f3 to 4d16a9c Compare July 5, 2024 06:06

dpgeorge merged commit 4d16a9c into micropython:master Jul 5, 2024

felixdoerre deleted the ipv6_docs branch July 7, 2024 16:29

Conversation

felixdoerre commented Mar 20, 2024

Uh oh!

Uh oh!

dpgeorge commented Mar 26, 2024

Uh oh!

dpgeorge commented Mar 26, 2024

Uh oh!

robert-hh commented Mar 26, 2024

Uh oh!

felixdoerre commented Mar 27, 2024

Uh oh!

robert-hh commented Mar 27, 2024

Uh oh!

dpgeorge commented Mar 27, 2024

Uh oh!

robert-hh commented Mar 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

felixdoerre commented Mar 27, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

felixdoerre commented Jun 4, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

felixdoerre Jun 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dpgeorge commented Jul 5, 2024

Uh oh!

felixdoerre commented Jul 6, 2024

Uh oh!

dpgeorge commented Jul 7, 2024

Uh oh!

razvanphp commented Sep 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

robert-hh commented Mar 27, 2024 •

edited

Loading

felixdoerre Jun 7, 2024 •

edited

Loading