Repository navigation
Fix 'make submodules' when building out-of-tree - #14344
Merged
Merged
Conversation
|
Code size report: |
When MicroPython is used as a submodule and built from the containing project, e.g. for the embed port, `make submodules` fails because it goes looking for the sub-sub-module paths in the outer repository instead of in the micropython repository. Fix this by invoking git inside the micropython submodule. Signed-off-by: Christian Walther <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14344 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 161 161
Lines 21204 21204
=======================================
Hits 20864 20864
Misses 340 340 ☔ View full report in Codecov by Sentry. |
dpgeorge
approved these changes
Aug 26, 2024
Member
|
Thanks, this change looks OK. The CI passes and that uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When MicroPython is used as a submodule and built using
makefrom the containing project, e.g. following the instructions for the embed port,make submodulesfails because it goes looking for the sub-sub-module paths in the outer repository instead of in the micropython repository.This is fixed by the attached commit: invoke
gitinside the micropython submodule instead of at the outer project level.(I initially thought that this would affect not just the embed port but also external board definitions, but it turns out it does not, because in the external-board-definition process MicroPython is build by a sub-
makethat operates inside the MicroPython submodule.)Steps to reproduce
Actual result
Expected result