Skip to content

stm32/can: Fix clearing filters on CAN3 (bxCAN). - #16545

Merged
dpgeorge merged 1 commit into
micropython:masterfrom
projectgus:bugfix/stm32_can3_clear_filter
Jan 17, 2025
Merged

stm32/can: Fix clearing filters on CAN3 (bxCAN).#16545
dpgeorge merged 1 commit into
micropython:masterfrom
projectgus:bugfix/stm32_can3_clear_filter

Conversation

@projectgus

@projectgus projectgus commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

Summary

This fix was split out from #15989.

The instance argument to HAL_CAN_ConfigFilter() is ignored for CAN1, CAN2 but needed for CAN3.

Testing

@github-actions

github-actions Bot commented Jan 8, 2025

Copy link
Copy Markdown

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +4 +0.001% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@projectgus projectgus mentioned this pull request Jan 8, 2025
Merged
@projectgus @dpgeorge
stm32/can: Fix clearing filters on CAN3 (bxCAN).
3a60f32 
HAL argument is ignored for CAN1, CAN2 but needed for CAN3.

Signed-off-by: Angus Gratton <[email protected]>
@dpgeorge
dpgeorge force-pushed the bugfix/stm32_can3_clear_filter branch from dca3580 to 3a60f32 Compare January 17, 2025 02:08
@dpgeorge
dpgeorge merged commit 3a60f32 into micropython:master Jan 17, 2025
@projectgus
projectgus deleted the bugfix/stm32_can3_clear_filter branch January 17, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpgeorge dpgeorge dpgeorge approved these changes

Assignees

No one assigned

Labels

port-stm32

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@projectgus @dpgeorge