Repository navigation
/esp32/boards: Add LOLIN_S3_PRO board definition. - #17290
mattytrentini wants to merge 1 commit into
Conversation
Signed-off-by: Matt Trentini <[email protected]>
85f6bcf to
3162970
Compare
This is now done, see commit 6201e77 Given that, does it still make sense to add this Lolin board definition? If so, please update this PR so it works with the new auto-sizing feature (basically, you don't need to specify the flash size or partitions csv). |
It doesn't add much on top of ESP32_GENERIC_S3. Really the only benefit is that it's more obvious which firmware is appropriate for Lolin S3 Pro users. Maybe we need to list 'community tested' boards for the ESP32_GENERIC* boards? In any case, I'm ok with closing this and directing Lolin S3 Pro users to the generic alternative. |
Yes, I think that's a good idea. Can easily just list them in the |
Summary
Added a board definition for the Wemos Lolin S3 Pro.
Testing
I deployed the firmware to my S3 Pro, it appeared to work fine. Tested the filesystem (since a key feature of this board is the 16MB flash) and the GRB (not RGB) LED:
Trade-offs and Alternatives
A user could define their own custom board. We could also extend ESP32_GENERIC_S3 to support 16MB models (which may be wroth doing as well).
See #17217 for a request for this board.