Repository navigation
tools/verifygitlog.py: Allow long co-author and sign-off names. - #17302
Merged
Merged
Conversation
|
Code size report: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17302 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 169 169
Lines 21897 21897
=======================================
Hits 21579 21579
Misses 318 318 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DvdGiessen
force-pushed
the
verifygitlog_long_names
branch
from
May 14, 2025 16:38
bb3190b to
2e02407
Compare
projectgus
approved these changes
May 14, 2025
projectgus
left a comment
projectgus
left a comment
Contributor
There was a problem hiding this comment.
Good idea, we should not punish the long-named (and long-emailed-addressed) authors amongst us. 😁
dpgeorge
approved these changes
May 15, 2025
Signed-off-by: Daniël van de Giessen <[email protected]>
dpgeorge
force-pushed
the
verifygitlog_long_names
branch
from
May 15, 2025 03:04
2e02407 to
4208970
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While rebasing #13390 I noticed that the commit messages were being rejected due to the author name on the required
Signed-off-by:line being longer than the maximum line length. I don't think we should be enforcing a maximum length for human names.This change disables the line length check for lines that start with
Co-authored-by:orSigned-off-by:.I've opened a sibling PR on for updating micropython-lib as well: micropython/micropython-lib#1007