Repository navigation
esp32/panichandler: Support building against IDFv5.4.2. - #17586
Merged
Merged
Conversation
dpgeorge
approved these changes
Jul 5, 2025
dpgeorge
left a comment
dpgeorge
left a comment
Member
There was a problem hiding this comment.
Thanks, looks OK to me (although I did not test it).
The IDF panic handler resets the watchdog timeout to prevent the printing of the error message from being cut off by a WDT reset. We use the exact same function call in our wrapper function for the same purpose. In IDFv5.4.2 the function used for this was changed from `esp_panic_handler_reconfigure_wdts` to `esp_panic_handler_feed_wdts`, specifically in this commit: espressif/esp-idf@cd887ef Signed-off-by: Daniël van de Giessen <[email protected]>
dpgeorge
force-pushed
the
esp32-panic-idf542
branch
from
July 5, 2025 14:15
9f0024b to
431b791
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A small follow-up to #14086, which implemented a wrapper around the built-in IDF panic handler to print additional MicroPython-specific information.
The IDF panic handler resets the watchdog timeout to prevent the printing of the error message from being cut off by a WDT reset. We use the exact same function call in our wrapper function for the same purpose.
In IDFv5.4.2 the function used for this was changed (from
esp_panic_handler_reconfigure_wdts, see here, toesp_panic_handler_feed_wdts, see here, specifically in this commit), and thus this PR introduces that same change into our wrapper.Testing
My previously described method for triggering a crash no longer works, so here's an updated version:
This results in the following output:
Decoded backtrace: