py/objstr: Fix b"".hex() so it returns an empty str object. - #18808

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.42%. Comparing base (bfc69db) to head (06bfefe).
⚠️ Report is 3 commits behind head on master.

@@            Coverage Diff             @@
##           master   #18808      +/-   ##
==========================================
- Coverage   98.42%   98.42%   -0.01%     
==========================================
  Files         174      174              
  Lines       22331    22329       -2     
==========================================
- Hits        21980    21978       -2     
  Misses        351      351              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Code size report:

Reference:  extmod,rp2: Keep LWIP timer running if lwip poll_sockets() is called. [bfc69db]
Comparison: py/objstr: Fix b"".hex() so it returns an empty str object. [merge of 06bfefe]
  mpy-cross:    +0 +0.000% 
   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:   +16 +0.002% standard
      stm32:    +8 +0.002% PYBV10
      esp32:   +24 +0.001% ESP32_GENERIC
     mimxrt:    +8 +0.002% TEENSY40
        rp2:   +16 +0.002% RPI_PICO_W
       samd:   +16 +0.006% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:   +16 +0.004% VIRT_RV32

py/objstr: Fix b"".hex() so it returns an empty bytes object.

As per CPython behaviour, b"".hex() should return an empty bytes object (not an empty str object).

Isn't it the other way round?

• Fix b"".hex() so it returns an empty str object
• As per CPython behaviour, b"".hex() should return an empty str object (not an empty bytes object).

(Code seems correct, but PR / commit message is confusing.)

Isn't it the other way round?

You are right! Thanks for picking that up, I've now updated the commit message and this PR text.