Skip to content

esp32/stm32: Use 4kiB output buffer for mbedtls sockets. - #5306

Closed
jimmo wants to merge 2 commits into
micropython:masterfrom
jimmo:mbedtls-buffers
Closed

esp32/stm32: Use 4kiB output buffer for mbedtls sockets.#5306
jimmo wants to merge 2 commits into
micropython:masterfrom
jimmo:mbedtls-buffers

Conversation

@jimmo

@jimmo jimmo commented Nov 7, 2019

Copy link
Copy Markdown
Member

See #5303 for more details, but in summary:

  • The default 16kiB output buffer (same as the input buffer) is expensive.
  • On ESP32 (non-psram) we don't have enough RAM available to allocate the original 16kiB due to RAM region fragmentation in IDF 4.x.

@dpgeorge

dpgeorge commented Nov 8, 2019

Copy link
Copy Markdown
Member

Thanks. I think for stm32 to wait until after v1.12 because it's a subtle change. But esp32 is needed for IDF4 to work so can go in now.

@dpgeorge

dpgeorge commented Nov 11, 2019

Copy link
Copy Markdown
Member

The esp32 change was merged in 71299d3

@dpgeorge

dpgeorge commented Dec 20, 2019

Copy link
Copy Markdown
Member

The stm32 change was merged in 90f2864

@dpgeorge dpgeorge closed this Dec 20, 2019
@Carglglz Carglglz mentioned this pull request Jan 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

port-esp32 port-stm32

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jimmo @dpgeorge