Repository navigation
Conversation
Contributor
|
Looks good to me. |
Contributor
|
Why not support use in an asynchronous context manager as per this attempt? |
Contributor
Author
|
Because context manager is a syntactic sugar requiring more code, and uasyncio's goal is to provide required functionality with the minimum of code. |
Contributor
Author
|
Ok, I'm still not sure about "synchro" part, but there're more things in queue, so merging this. As I figure noone really tested this, I'm leaving debug statements in the code. |
Contributor
Author
|
To clarify, this was developed to have an example on non-I/O-waiting coroutine which is fully suspended from the main scheduling queue (to be able to test cancellation algorithm and make sure that the proposed solution, which required patching the language core, is fully general). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dpgeorge , @peterhinch : Please reviews. Points to consider: