Repository navigation
Converted strict-export-declare-modifiers from TSLint to ESLint, ish - #680
Merged
Nathan Shively-Sanders (sandersn) merged 4 commits intoSep 22, 2023
Conversation
Josh Ghoulberg 👻 (JoshuaKGoldberg)
marked this pull request as ready for review
May 21, 2023 11:23
Josh Ghoulberg 👻 (JoshuaKGoldberg)
requested review from
Andrew Branch (andrewbranch) and
Nathan Shively-Sanders (sandersn)
as code owners
May 21, 2023 11:23
Nathan Shively-Sanders (sandersn)
approved these changes
Sep 22, 2023
Nathan Shively-Sanders (sandersn)
left a comment
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
I think it's OK to leave the TS-centric code for now. I don't believe we've had trouble with the tslint rule unlike some others that have broken with TS API changes over the years.
Josh Ghoulberg 👻 (JoshuaKGoldberg)
deleted the
strict-export-declare-modifiers
branch
September 22, 2023 19:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #648 by migrating
strict-export-declare-modifiersfrom TSLint to ESLint......mostly. This removes the dependency on
tslintbut still operates on the TS tree instead of TSESTree tree. I ran out of energy overhauling these more TypeScript-intertwined rules... is this ok as an intermediary step?