Repository navigation
Optimize BC7 parity bit calculation - #83
Closed
Eric Lasota (elasota) wants to merge 1 commit into
Closed
Eric Lasota (elasota) wants to merge 1 commit into
Eric Lasota (elasota) wants to merge 1 commit into
Conversation
… every possible combination.
Collaborator
|
I'll be taking a look at this this week. I'm setting up a test run to validate quality/time between the two versions. |
Contributor
Author
|
This one should be producing identical output, you should be able to just compress a bunch of test images and compare their checksums. |
Chuck Walbourn (walbourn)
force-pushed
the
master
branch
from
April 12, 2018 02:27
c8950df to
79799e4
Compare
Collaborator
|
I'll take this PR once I have my BC validator test done... I've been focused on VS 2017 (15.7 update) and Windows 10 SDK (17134) the past month, so I'm getting back to this... |
Collaborator
|
Thanks again. Fixed in this commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major speed optimization, reduces encode times with -bcmax in particular by more than half.
The current encoder solves parity bits by trying the block with every possible P-bit combination. Most of these combinations are redundant in partitioned modes because the P-bits are associated with independent subsets, so it can loop far fewer times by solving each subset separately instead of the entire block.
Mode 0 is the most affected, its loop count is reduced by a factor of 16.