Skip to content

XML Translation Removal - #1056

Merged
Andrew Wang (WardenGnaw) merged 2 commits into
mainfrom
dev/waan/removeXMLTranslation
Oct 19, 2020
Merged

XML Translation Removal#1056
Andrew Wang (WardenGnaw) merged 2 commits into
mainfrom
dev/waan/removeXMLTranslation

Conversation

@WardenGnaw

@WardenGnaw Andrew Wang (WardenGnaw) commented Oct 12, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

This PR is to remove the conversion that OpenDebugAD7 does to pass the configuration used to launch/attach processes for GDB.

This will now parse the necessary fields on the json and pass it to MIEngine.

Testing Matrix

Scenario Host OS Remote OS Debugger Status
Local Launch Windows N/A MinGW GDB ✅
Local Attach Windows N/A MinGW GDB ✅
Pipe Launch Windows Linux GDB 7.12-6 ✅
Pipe Attach Windows Linux GDB 7.12-6 ✅
Local Launch Linux N/A GDB 9.1 + GDBServer ✅

Integration Tests w/ C++ Extension

OS Status Notes
Windows ✅ TestOptimizedSharedLib is failing to disconnect but it passes in other runs
Linux ✅

@WardenGnaw Andrew Wang (WardenGnaw) linked an issue Oct 13, 2020 that may be closed by this pull request
[VSCode] Implement UseForBreakpoints for sourceFileMap with the C++ extension #819
Closed
@WardenGnaw
Andrew Wang (WardenGnaw) force-pushed the dev/waan/removeXMLTranslation branch from b25435f to d095814 Compare October 14, 2020 02:03
@WardenGnaw
Andrew Wang (WardenGnaw) marked this pull request as ready for review October 14, 2020 02:04
@WardenGnaw Andrew Wang (WardenGnaw) changed the title [DRAFT] XML Translation Removal XML Translation Removal Oct 14, 2020
@gregg-miskelly

Gregg Miskelly (gregg-miskelly) commented Oct 14, 2020

Copy link
Copy Markdown
Member 
            {

Any idea why this only fails if we are debugging a core dump?

Refers to: src/OpenDebugAD7/AD7DebugSession.cs:1124 in d095814. [](commit_id = d095814, deletion_comment = False)

gregg-miskelly
Gregg Miskelly (gregg-miskelly) reviewed Oct 14, 2020
View reviewed changes
Comment thread src/OpenDebugAD7/AD7DebugSession.cs Outdated
gregg-miskelly
Gregg Miskelly (gregg-miskelly) reviewed Oct 14, 2020
View reviewed changes
Comment thread src/OpenDebugAD7/AD7DebugSession.cs Outdated
gregg-miskelly
Gregg Miskelly (gregg-miskelly) reviewed Oct 14, 2020
View reviewed changes
Comment thread src/MICore/LaunchOptions.cs
gregg-miskelly
Gregg Miskelly (gregg-miskelly) approved these changes Oct 14, 2020
View reviewed changes

@gregg-miskelly Gregg Miskelly (gregg-miskelly) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@WardenGnaw
Andrew Wang (WardenGnaw) force-pushed the dev/waan/removeXMLTranslation branch from d095814 to e1d7eb8 Compare October 14, 2020 22:10
@WardenGnaw
Andrew Wang (WardenGnaw) force-pushed the dev/waan/removeXMLTranslation branch from e1d7eb8 to 91cac50 Compare October 19, 2020 18:36
@WardenGnaw
Andrew Wang (WardenGnaw) deleted the dev/waan/removeXMLTranslation branch October 20, 2020 20:51
@Luka234 Luka234 mentioned this pull request Oct 29, 2020
Open
@WardenGnaw Andrew Wang (WardenGnaw) mentioned this pull request Oct 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregg-miskelly Gregg Miskelly (gregg-miskelly) gregg-miskelly approved these changes
@pieandcakes Pierson Lee (pieandcakes) Awaiting requested review from pieandcakes

Assignees

@WardenGnaw Andrew Wang (WardenGnaw)

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[VSCode] Implement UseForBreakpoints for sourceFileMap with the C++ extension

2 participants

@WardenGnaw @gregg-miskelly