Repository navigation
Fix DebugServerPath for JSON parsing - #1070
Merged
Merged
Conversation
The XML creation for InitializeServerOptions checks for DebugServerPath being null or whitespace. Making JSON's InitializeServerOptions the same.
Andrew Wang (WardenGnaw)
requested review from
Gregg Miskelly (gregg-miskelly) and
paulmaybee
October 29, 2020 17:57
Gregg Miskelly (gregg-miskelly)
approved these changes
Oct 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XML creation for InitializeServerOptions checks for DebugServerPath
being null or whitespace. Making JSON's InitializeServerOptions the
same.
See:
MIEngine/src/MICore/LaunchOptions.cs
Lines 461 to 476 in 728f403