Skip to content

Allow template strings (with no interpolated expressions) to start off with literal types #16592

Closed
Closed
Allow template strings (with no interpolated expressions) to start off with literal types#16592
Labels
BugA bug in TypeScriptDomain: Literal TypesUnit types including string literal types, numeric literal types, Boolean literals, null, undefinedFixedA PR has been merged for this issue
Milestone
TypeScript 2.6

Description

@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)
opened on Jun 16, 2017

I can't find the original issue (if there is one).

const c: "hello" = `hello`

Expected: No error.
Actual: Type 'string' is not assignable to type '"hello"'.

We should just allow people to use NoSubstitutionTemplates the way that they're allowed to use regular strings.

Activity

  1. Daniel Rosenwasser (DanielRosenwasser)
    added
    BugA bug in TypeScript
    Domain: Literal TypesUnit types including string literal types, numeric literal types, Boolean literals, null, undefined
    SuggestionAn idea for TypeScript
    and removed
    BugA bug in TypeScript
    on Jun 16, 2017

  2. ericbf commented on Sep 5, 2017

    @ericbf
    Eric Ferreira (ericbf)
    on Sep 5, 2017
    Contributor

    This should also cover using NoSubstitutionTemplates as literal types as in #18109

  3. ericbf commented on Sep 13, 2017

    @ericbf
    Eric Ferreira (ericbf)
    on Sep 13, 2017
    Contributor

    Is there any progress being made on this?

    Andy (Andrewkraft) (@Andy-MS) the PR that referenced this issue didn't completely resolve the cases covered by using NoSubstitutionTemplates as literal types.

  4. Ryan Cavanaugh (RyanCavanaugh)
    added
    Help WantedYou can do this
    BugA bug in TypeScript
    and removed
    SuggestionAn idea for TypeScript
    on Sep 13, 2017
  5. ghost closed this as completedin #18452on Sep 14, 2017
  6. ghost added
    FixedA PR has been merged for this issue
    on Sep 14, 2017
  7. ghost removed
    Help WantedYou can do this
    on Sep 14, 2017
  8. Mohamed Hegazy (mhegazy)
    added this to the TypeScript 2.6 milestone on Sep 14, 2017
  9. microsoft
    locked and limited conversation to collaborators on Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugA bug in TypeScriptDomain: Literal TypesUnit types including string literal types, numeric literal types, Boolean literals, null, undefinedFixedA PR has been merged for this issue

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions