Skip to content

Inline local refactoring #18459

Closed
#54281
Closed
Inline local refactoring#18459
#54281
Assignees
MariaSolOs
Labels
Domain: LS: Refactoringse.g. extract to constant or function, rename symbolFix AvailableA PR has been opened for this issueIn DiscussionNot yet reached consensusSuggestionAn idea for TypeScriptVS Code TrackedThere is a VS Code equivalent to this issue
Milestone
TypeScript 5.2.0

Description

@mjbvz
Matt Bierner (mjbvz)
opened on Sep 14, 2017

Proposal
Add a refactoring to inline a local variable. Example:

function generatePipeName(): string {
	const hexString = makeRandomHexString(40);
	return getPipeName(hexString);
}

The Inline local refactoring on hexString would result in:

function generatePipeName(): string {
	return getPipeName(makeRandomHexString(40));
}

Activity

  1. Matt Bierner (mjbvz)
    added
    VS Code TrackedThere is a VS Code equivalent to this issue
    on Sep 14, 2017
  2. Daniel Rosenwasser (DanielRosenwasser)
    added
    Domain: LS: Refactoringse.g. extract to constant or function, rename symbol
    SuggestionAn idea for TypeScript
    on Sep 14, 2017
  3. Ryan Cavanaugh (RyanCavanaugh)
    added
    Experience EnhancementNoncontroversial enhancements
    on Aug 22, 2018
  4. Wesley Wigham (weswigham)
    added
    In DiscussionNot yet reached consensus
    on Nov 6, 2018

  5. D0nGiovanni commented on Nov 7, 2018

    @D0nGiovanni
    Giovanni (D0nGiovanni)
    on Nov 7, 2018
    Contributor

    I've been working on this issue for a while now, but I'm not too familiar with the compiler API. Is there a way to dynamically generate a new node based on the SyntaxKind of another? I'm concerned that if I just make a copy, the id will stay the same and that would lead to problems down the road.

  6. D0nGiovanni commented on Nov 8, 2018

    @D0nGiovanni
    Giovanni (D0nGiovanni)
    on Nov 8, 2018
    Contributor

    Wesley Wigham (@weswigham) What is the label in discussion for? Is it being discussed whether to implement the issue at all, or is there a different meaning? I would like to implement it in the near future (1-2 weeks).

  7. weswigham commented on Nov 8, 2018

    @weswigham
    Wesley Wigham (weswigham)
    on Nov 8, 2018
    Member

    Ah, just means we're considering it for inclusion. Everything that's labeled as a "Suggestion" is supposed to have one of a set of sublabels indicative of the issue's state. I felt that was probably most correct here (it's not "committed" because we've not allocated anyone to work on it).

  8. Ryan Cavanaugh (RyanCavanaugh)
    removed
    Experience EnhancementNoncontroversial enhancements
    on Apr 25, 2019

  9. jackric commented on Jul 7, 2020

    @jackric
    Jack (jackric)
    on Jul 7, 2020

    Anyone suggest a VSCode extension that does this in lieu of waiting for official support?

  10. OliverJAsh commented on Aug 28, 2020

    @OliverJAsh
    Oliver Joseph Ash (OliverJAsh)
    on Aug 28, 2020
    Contributor

    Anyone suggest a VSCode extension that does this in lieu of waiting for official support?

    https://github.com/nicoespeon/abracadabra#inline-variable

  11. olfek commented on Mar 19, 2023

    @olfek
    olfek (olfek)
    on Mar 19, 2023

    2023

  12. Daniel Rosenwasser (DanielRosenwasser)
    added this to the TypeScript 5.2.0 milestone on May 11, 2023
  13. Daniel Rosenwasser (DanielRosenwasser)
    assigned
    Maria Solano (MariaSolOs)
    on May 11, 2023
  14. TypeScript Bot (typescript-bot)
    added
    Fix AvailableA PR has been opened for this issue
    on May 16, 2023
  15. Maria Solano (MariaSolOs)
    closed this as completedin #54281on Jun 13, 2023

  16. tylerlaprade commented on Jun 14, 2023

    @tylerlaprade
    Tyler C Laprade, CFA (tylerlaprade)
    on Jun 14, 2023

    Thanks Maria Solano (@MariaSolOs) for the fix! Will the documentation be updated to match?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Domain: LS: Refactoringse.g. extract to constant or function, rename symbolFix AvailableA PR has been opened for this issueIn DiscussionNot yet reached consensusSuggestionAn idea for TypeScriptVS Code TrackedThere is a VS Code equivalent to this issue

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions