In JS, both module.exports assignments and property assignments should be allowed in a single file

Code

// @noEmit: true
// @allowJs: true
// @checkJs: true
// @Filename: a.js

// modified from graceful-fs
module.exports = patch
module.exports.close = function (fs$close) {
}
function patch(fs) {
    // do something with Fs
}

Expected behavior:
No errors, and graceful-fs creates a callable module with an exported member patch.

Actual behavior:
Lots of errors, and no exported member patch.

This should be true for exports assignments too, and when the assignments are out of order, and when some property assignments are to exports and some to the alias. Here's an example based on uglify's code:

// @noEmit: true
// @allowJs: true
// @checkJs: true
// @Filename: ugly.js
// from uglify-js
var FILES = exports.FILES = [
    "./a.js",
    "./b.js"
]
var ugly = exports
ugly.ast.warn = function (txt) {
    return "WARN: " + txt
}
exports.other = function(files) {
}

// @Filename: use.js
var ugly = require('./ugly')
ugly.ast.warn('oh no')
ugly.other(ugly.FILES)

Webpack uses this pattern once or twice: https://github.com/mohsen1/webpack/tree/bd1c827c884d943f68bbbf00cd91003875ae0bb2

Navigation Menu

Repository navigation

In JS, both module.exports assignments and property assignments should be allowed in a single file #22461

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

In JS, both module.exports assignments and property assignments should be allowed in a single file #22461

Description

Activity

sandersn commented on Mar 10, 2018

sandersn commented on Apr 4, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions