Type narrowing doesn't work with mutable variables in closures #23776

Activity

1. falsandtru commented on Apr 30, 2018

   

   falsandtru (falsandtru)

   on Apr 30, 2018

   ContributorAuthor

   More actions

   Seems like it also breaks colorization.
3. ghost added

   DuplicateAn existing issue was already createdAn existing issue was already created

   on Apr 30, 2018
4. falsandtru commented on Apr 30, 2018

   

   falsandtru (falsandtru)

   on Apr 30, 2018

   ContributorAuthor

   More actions

   Indeed.

   On the colorization, the last return keyword is white, should be blue.

       if (process instanceof Coroutine) return this.register(
         name,
         {
           init: state => state,
           main: (param, state) =>
             (process as Coroutine<R, R, P>)[Coroutine.port].send(param)
               .then<Supervisor.Process.Result<R, S>>(({ value: reply, done }) =>
                 done
                   ? void this.kill(name, undefined) ||
                     (process as Coroutine<R, R, P>).then<Supervisor.Process.Result<R, S>>(reply =>
                       [reply, state])
                   : [reply, state,]),
           exit: reason => void process[Coroutine.terminator](reason),
         },
         state,
         reason);
       return super.register(name, process, state);

   https://github.com/falsandtru/spica/blob/v0.0.167/src/supervisor.es2018.ts#L29
6. falsandtru commented on Apr 30, 2018

   

   falsandtru (falsandtru)

   on Apr 30, 2018

   ContributorAuthor

   More actions

   Hm, I'm using VSCode v1.22.2 on Win10.
8. falsandtru commented on Apr 30, 2018

   

   falsandtru (falsandtru)

   on Apr 30, 2018

   ContributorAuthor

   More actions

   Dark (Visual Studio).
10. falsandtru commented on Apr 30, 2018

    

    falsandtru (falsandtru)

    on Apr 30, 2018

    ContributorAuthor

    More actions

    Oh No! Please open and check https://github.com/falsandtru/spica/blob/v0.0.167/src/supervisor.es2018.ts#L29 via vscode!
12. falsandtru commented on Apr 30, 2018

    

    falsandtru (falsandtru)

    on Apr 30, 2018

    ContributorAuthor

    More actions

    This is my screenshot.

    
13. falsandtru commented on Apr 30, 2018

    

    falsandtru (falsandtru)

    on Apr 30, 2018

    Last edited by falsandtru

    ContributorAuthor

    More actions

    Looks like the error is only present in vscode non-insiders without the latest grammar installed.

    I see, I wait for the next release. Currently, this is not a serious problem for me.
15. falsandtru commented on Apr 30, 2018

    

    falsandtru (falsandtru)

    on Apr 30, 2018

    ContributorAuthor

    More actions

    Resolved, thanks for letting me know!
16. microsoft

    locked and limited conversation to collaborators on Jul 31, 2018