Repository navigation
const x = require("m") should create an alias symbol #25533
Description
TypeScript Version: 3.0.0-dev.20180707
Code
/// <reference path='fourslash.ts'/>
// @allowJs: true
// @Filename: /a.js
////function [|{| "isWriteAccess": true, "isDefinition": true |}x|]() {};
////module.exports = [|x|];
// @Filename: /b.js
////const [|x|] = require("./a");
////[|x|];
const [r0, r1, r2, r3] = test.ranges();
verify.referenceGroups(r2, [/*todo*/]);Expected behavior:
x in const x is an alias of the x in function x() {}, so all references are found.
Actual behavior:
x is a variable that happens to be the same type as the other x. Only references in b.js are found.
Activity
sandersn commentedon Jul 16, 2018
The in-file type of commonjs modules is usually wrong, so I'll have to fix bugs related to that before aliasing will really make sense. I will look at #25621 first.
sandersn commentedon Jul 20, 2018
Turns out github didn't recognise that the "fix #xxxx" syntax occurred in a conditional clause and unconditionally closed this issue. :) Thanks for re-opening.
3 remaining items
Jessidhia commentedon Jan 17, 2019
That's only correct if the
module.exportsis never reassigned...... but that's the best we can do in ES modules. That is also a limitation of node's--experimentalModules.sandersn commentedon Mar 13, 2019
Note that the type of
module.exportsinside a module is now correctly checked, which unblocks fixing this issue.