Skip to content

Rush's node_modules structure is not resolved in vscode correctly #28689

Closed
#37387
Closed
Rush's node_modules structure is not resolved in vscode correctly#28689
#37387
Assignees
sheetalkamat
Labels
Fix AvailableA PR has been opened for this issueScenario: Monorepos & Cross-Project ReferencesRelates to composite projects (a.k.a references between "medium sized projects")
Milestone
TypeScript 3.9.0

Description

@nfour
Sam J (nfour)
opened on Nov 22, 2018
  • VSCode Version: 1.28.2 (or insiders)
  • OS Version: Arch linux

When trying to auto-import node modules within a rush project, intellisense will not locate dependencies. This also results in the editor crashing or re-initializing the TS server somewhat often.

This is likely due to rush's unique node module structure, and it's unclear if this ever worked as I have only adopted rush somewhat recently.

Steps to Reproduce:

You can replicate this issue within the web-build-tools repo itself.

  1. Open https://github.com/Microsoft/web-build-tools/blob/master/libraries/ts-command-line/src/index.ts
  2. type Colors in the top level (from the colors module). You shouldn't be able to resolve the symbol.

eg.

const foo: Colors = {};

export {
  CommandLineAction,
  ICommandLineActionOptions
} from './CommandLineAction';

This also seems to correlate with the editor's TS server crashing intermittently, but its not clear how to reproduce.

Does this issue occur when all extensions are disabled?: Yes

Versions tested:

  • rush v5.5.2 / v5.3.0
  • node 6 / node 10
  • vscode v1.28.2 / insiders
  • with either of: npm, yarn or pnpm (all latest)
  • has been tested on multiple linux systems

Workaround

If you execute the below script to replace symlinks with real files:

mv node_modules node_modules_old
rsync node_modules_old/ node_modules/ -a --copy-links -v

Everything should work as expected.

There seems to be an issue with symlinks.

Related: microsoft/rushstack#955

Activity

  1. Alex Ross (alexr00)
    assigned
    Alexandru Dima (alexdima)
    on Nov 22, 2018
  2. Alexandru Dima (alexdima)
    assigned
    Matt Bierner (mjbvz)
    and unassigned
    Alexandru Dima (alexdima)
    on Nov 23, 2018

  3. octogonz commented on Nov 27, 2018

    @octogonz
    Pete Gonzalez (octogonz)
    on Nov 27, 2018

    Matt Bierner (@mjbvz) let us know if there's any help you need investigating this issue. Rush is pretty widely used internally at Microsoft, so if there is a problem with its symlinking strategy, we'd like to get that fixed.

    I'll point out that the symbolic links were recently converted to use relative paths. I wonder if that could be related...

  4. Matt Bierner (mjbvz)
    transferred this issue frommicrosoft/vscodeon Nov 27, 2018
  5. Matt Bierner (mjbvz)
    removed their assignment
    on Nov 27, 2018
  6. Wesley Wigham (weswigham)
    added
    BugA bug in TypeScript
    Needs InvestigationThis issue needs a team member to investigate its status.
    Scenario: Monorepos & Cross-Project ReferencesRelates to composite projects (a.k.a references between "medium sized projects")
    on Nov 27, 2018

  7. nfour commented on Nov 29, 2018

    @nfour
    Sam J (nfour)
    on Nov 29, 2018
    Author

    Seems I am getting this error in the TSServer output panel of vscode:

    [Error  - 10:56:03 AM] 'signatureHelp' request failed with error.
Error processing request. Cannot read property 'pos' of undefined
TypeError: Cannot read property 'pos' of undefined
    at Object.rangeContainsRange (/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/tsserver.js:92870:41)
    at _loop_6 (/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/tsserver.js:103736:36)
    at getContainingArgumentInfo (/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/tsserver.js:103743:31)
    at Object.getSignatureHelpItems (/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/tsserver.js:103358:32)
    at Object.getSignatureHelpItems (/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/tsserver.js:117586:37)
    at IOSession.Session.getSignatureHelpItems (/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/tsserver.js:125409:62)
    at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/tsserver.js:124364:61)
    at /opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/tsserver.js:125830:88
    at IOSession.Session.executeWithRequestId (/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/tsserver.js:125821:28)
    at IOSession.Session.executeCommand (/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/tsserver.js:125830:33)
    at IOSession.Session.onMessage (/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/tsserver.js:125852:35)
    at Interface.<anonymous> (/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/tsserver.js:127112:27)
    at emitOne (events.js:116:13)
    at Interface.emit (events.js:211:7)
    at Interface._onLine (readline.js:282:10)
    at Interface._normalWrite (readline.js:424:12)
    at Socket.ondata (readline.js:141:10)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:250:11)
    at Socket.Readable.push (_stream_readable.js:208:10)
    at Pipe.onread (net.js:594:20)
[Error  - 11:12:41 AM] 'signatureHelp' request failed with error.

    This correlates with the TS Server showing Loading... on hover over stuff that should be typed.

    The tsserver-log contains the below around that time (before).

    [11:6:20.480] Got install request {"projectName":"/dev/null/inferredProject1*","fileNames":["/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.es5.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.es2015.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.es2016.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.dom.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.dom.iterable.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.webworker.importscripts.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.scripthost.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.es2015.core.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.es2015.collection.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.es2015.generator.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.es2015.iterable.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.es2015.promise.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.es2015.proxy.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.es2015.reflect.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.es2015.symbol.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.es2016.array.include.d.ts","/opt/visual-studio-code-insiders/resources/app/extensions/node_modules/typescript/lib/lib.es2016.full.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/bluebird/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/execa/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/fs-extra/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/inquirer/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/jest/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/js-yaml/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/lodash/common/common.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/lodash/common/array.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/lodash/common/collection.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/lodash/common/date.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/lodash/common/function.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/lodash/common/lang.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/lodash/common/math.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/lodash/common/number.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/lodash/common/object.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/lodash/common/seq.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/lodash/common/string.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/lodash/common/util.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/lodash/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/puppeteer/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/uuid/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/yargs/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/aws-sdk/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/moment/moment.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/ts-jest/dist/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/ts-node/dist/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/tslint/lib/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/typescript/lib/typescript.d.ts"],"compilerOptions":{"module":1,"target":3,"jsx":1,"checkJs":true,"allowJs":true,"allowSyntheticDefaultImports":true,"allowNonTsExtensions":true,"noEmitForJsFiles":true},"typeAcquisition":{"enable":true,"include":[],"exclude":[]},"unresolvedImports":["make-error"],"projectRootPath":"/home/sam/W/TEMANDO/temonodo/tests/suite","kind":"discover"}
[11:6:20.480] Explicitly included types: []
[11:6:20.481] Typing names in '/home/sam/W/TEMANDO/temonodo/tests/suite/package.json' dependencies: ["@temando/errors","@temando/marco","@temando/schemas","@temando/sdk","@types/bluebird","@types/execa","@types/fs-extra","@types/inquirer","@types/jest","@types/js-yaml","@types/lodash","@types/node","@types/puppeteer","@types/uuid","@types/yargs","aws-sdk","bluebird","colors","execa","fermenter","fs-extra","inquirer","jest-environment-node","jest","js-yaml","lodash","moment","puppeteer","signal-exit","ts-jest","ts-node","tslint-config-temando","tslint","typescript","uuid","yargs"]
[11:6:20.503] Searching for typing names in /home/sam/W/TEMANDO/temonodo/tests/suite/node_modules; all files: ["/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/aws-sdk/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/bluebird/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/colors/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/execa/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/fermenter/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/fermenter/tsconfig.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/fermenter/tslint.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/fs-extra/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/inquirer/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/jest/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/jest-environment-node/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/jest-spec-reporter/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/js-yaml/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/lodash/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/moment/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/puppeteer/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/signal-exit/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/ts-jest/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/ts-jest/tsconfig.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/ts-jest/tslint.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/ts-node/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/tslint/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/tslint-config-temando/package-deps.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/tslint-config-temando/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/tslint-config-temando/tsconfig.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/tslint-config-temando/tslint.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/typescript/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/uuid/.eslintrc.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/uuid/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/yargs/package.json"]
[11:6:20.504]     Package 'aws-sdk' provides its own types.
[11:6:20.512]     Package 'moment' provides its own types.
[11:6:20.514]     Package 'ts-jest' provides its own types.
[11:6:20.515]     Package 'ts-node' provides its own types.
[11:6:20.515]     Package 'tslint' provides its own types.
[11:6:20.518]     Package 'typescript' provides its own types.
[11:6:20.520]     Found package names: ["bluebird","colors","execa","fermenter","fs-extra","inquirer","jest","jest-environment-node","jest-spec-reporter","js-yaml","lodash","puppeteer","signal-exit","tslint-config-temando","uuid","yargs"]
[11:6:20.520] Inferred typings from unresolved imports: ["make-error"]
[11:6:20.520] Result: {"cachedTypingPaths":["/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/aws-sdk/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/bluebird/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/execa/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/fs-extra/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/inquirer/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/jest/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/js-yaml/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/lodash/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/moment/moment.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/puppeteer/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/ts-jest/dist/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/ts-node/dist/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/tslint/lib/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/typescript/lib/typescript.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/uuid/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/yargs/index.d.ts"],"newTypingNames":["@temando/errors","@temando/marco","@temando/schemas","@temando/sdk","@types/bluebird","@types/execa","@types/fs-extra","@types/inquirer","@types/jest","@types/js-yaml","@types/lodash","@types/node","@types/puppeteer","@types/uuid","@types/yargs","colors","fermenter","jest-environment-node","signal-exit","tslint-config-temando","jest-spec-reporter","make-error"],"filesToWatch":["/home/sam/W/TEMANDO/temonodo/tests/suite/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/bower_components","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules"]}
[11:6:20.520] Finished typings discovery: {"cachedTypingPaths":["/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/aws-sdk/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/bluebird/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/execa/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/fs-extra/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/inquirer/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/jest/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/js-yaml/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/lodash/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/moment/moment.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/puppeteer/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/ts-jest/dist/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/ts-node/dist/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/tslint/lib/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/typescript/lib/typescript.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/uuid/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/yargs/index.d.ts"],"newTypingNames":["@temando/errors","@temando/marco","@temando/schemas","@temando/sdk","@types/bluebird","@types/execa","@types/fs-extra","@types/inquirer","@types/jest","@types/js-yaml","@types/lodash","@types/node","@types/puppeteer","@types/uuid","@types/yargs","colors","fermenter","jest-environment-node","signal-exit","tslint-config-temando","jest-spec-reporter","make-error"],"filesToWatch":["/home/sam/W/TEMANDO/temonodo/tests/suite/package.json","/home/sam/W/TEMANDO/temonodo/tests/suite/bower_components","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules"]}
[11:6:20.520] Installing typings ["@temando/errors","@temando/marco","@temando/schemas","@temando/sdk","@types/bluebird","@types/execa","@types/fs-extra","@types/inquirer","@types/jest","@types/js-yaml","@types/lodash","@types/node","@types/puppeteer","@types/uuid","@types/yargs","colors","fermenter","jest-environment-node","signal-exit","tslint-config-temando","jest-spec-reporter","make-error"]
[11:6:20.520] '@temando/errors' is in missingTypingsSet - skipping...
[11:6:20.521] '@temando/marco' is in missingTypingsSet - skipping...
[11:6:20.521] '@temando/schemas' is in missingTypingsSet - skipping...
[11:6:20.521] '@temando/sdk' is in missingTypingsSet - skipping...
[11:6:20.521] '@types/bluebird' is in missingTypingsSet - skipping...
[11:6:20.521] '@types/execa' is in missingTypingsSet - skipping...
[11:6:20.521] '@types/fs-extra' is in missingTypingsSet - skipping...
[11:6:20.521] '@types/inquirer' is in missingTypingsSet - skipping...
[11:6:20.521] '@types/jest' is in missingTypingsSet - skipping...
[11:6:20.521] '@types/js-yaml' is in missingTypingsSet - skipping...
[11:6:20.521] '@types/lodash' is in missingTypingsSet - skipping...
[11:6:20.521] '@types/node' is in missingTypingsSet - skipping...
[11:6:20.521] '@types/puppeteer' is in missingTypingsSet - skipping...
[11:6:20.521] '@types/uuid' is in missingTypingsSet - skipping...
[11:6:20.521] '@types/yargs' is in missingTypingsSet - skipping...
[11:6:20.521] Entry for package 'colors' does not exist in local types registry - skipping...
[11:6:20.521] Entry for package 'fermenter' does not exist in local types registry - skipping...
[11:6:20.521] Entry for package 'jest-environment-node' does not exist in local types registry - skipping...
[11:6:20.521] Entry for package 'signal-exit' does not exist in local types registry - skipping...
[11:6:20.521] Entry for package 'tslint-config-temando' does not exist in local types registry - skipping...
[11:6:20.521] Entry for package 'jest-spec-reporter' does not exist in local types registry - skipping...
[11:6:20.521] Entry for package 'make-error' does not exist in local types registry - skipping...
[11:6:20.521] All typings are known to be missing or invalid - no need to install more typings
[11:6:20.521] Sending response:
    {"projectName":"/dev/null/inferredProject1*","typeAcquisition":{"enable":true,"include":[],"exclude":[]},"compilerOptions":{"module":1,"target":3,"jsx":1,"checkJs":true,"allowJs":true,"allowSyntheticDefaultImports":true,"allowNonTsExtensions":true,"noEmitForJsFiles":true},"typings":["/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/aws-sdk/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/bluebird/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/execa/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/fs-extra/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/inquirer/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/jest/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/js-yaml/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/lodash/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/moment/moment.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/puppeteer/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/ts-jest/dist/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/ts-node/dist/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/tslint/lib/index.d.ts","/home/sam/W/TEMANDO/temonodo/tests/suite/node_modules/typescript/lib/typescript.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/uuid/index.d.ts","/home/sam/.cache/typescript/3.2/node_modules/@types/yargs/index.d.ts"],"unresolvedImports":["make-error"],"kind":"action::set"}
[11:6:20.521] Response has been sent.
[11:19:22.360] Parent process has exited, shutting down...

    The [11:19:22.360] Parent process has exited, shutting down... is when I manually restarted the TS Server as it was failing to validate my code.

  8. sheetalkamat commented on Nov 29, 2018

    @sheetalkamat
    Sheetal Nandi (sheetalkamat)
    on Nov 29, 2018
    Member

    Do I need to do anything special apart from cloning repo, opening file and typing the statement mentioned? I followed those steps (with typescript nightly build) but that seem to work as intended. Do not see any process shutdown or crash. Let me know if I need to do something else. If possible please share full tsserver log so we can see where things might be going south. Thanks.

    You can enable log level verbose in settigns and open and log and share tsserver and ti log or upload them using

    1. With "typescript.tsserver.log": "verbose" enabled
    2. Restart vscode or vscode insiders
    3. Reproduce the problem
    4. Run code --upload-logs on the command line (or code-insiders --upload-logs if using vscode insiders) and follow instructions
    5. Share the log file ID

  9. nfour commented on Dec 3, 2018

    @nfour
    Sam J (nfour)
    on Dec 3, 2018
    Author

    Sheetal Nandi (@sheetalkamat)

    To replicate, by following those steps you should have not have gotten the auto-import suggestion and no auto-fix bubble. Is this the case for you?

    The TS Server crashing is intermittent and harder to replicate.

    I'll be sure to use that command when it happens again, as verbose is enabled.

  10. sheetalkamat commented on Dec 3, 2018

    @sheetalkamat
    Sheetal Nandi (sheetalkamat)
    on Dec 3, 2018
    Member

    To replicate, by following those steps you should have not have gotten the auto-import suggestion and no auto-fix bubble. Is this the case for you?

    Yes that's exactly what I saw. (Used typescript@next)

  11. nfour commented on Dec 6, 2018

    @nfour
    Sam J (nfour)
    on Dec 6, 2018
    Author

    Sheetal Nandi (@sheetalkamat)

    Uploaded the logs when I noticed that the TS Server was hanging while trying to initialize (going on 5mins now!). VScode is basically unusable with TS:

    Upload successful! Log file ID: 134282124

  12. sheetalkamat commented on Dec 6, 2018

    @sheetalkamat
    Sheetal Nandi (sheetalkamat)
    on Dec 6, 2018
    Member

    Sam J (@nfour) Looking at the log it seems like there are lot of DirectoryWatchers being invoked. Many of them are through failed lookup locations of the sources in project. Is it possible to share the repro project? We can sign nda if needed. (send it to me in email) I would also like to discuss with you about the different directoryWatcher locations that I see and reason about them but I am not sure if your code is private so let me know if we can continue the discussion here on email thread. If email, please contact me at shkamat at microsoft dot com. Thanks.

  13. 35 remaining items

  14. Sheetal Nandi (sheetalkamat)
    self-assigned this
    on Mar 10, 2020
  15. Sheetal Nandi (sheetalkamat)
    added
    Needs InvestigationThis issue needs a team member to investigate its status.
    and removed
    Needs More InfoThe issue still hasn't been fully clarified
    on Mar 10, 2020
  16. Sheetal Nandi (sheetalkamat)
    modified the milestones: Backlog, TypeScript 3.9.0 on Mar 10, 2020

  17. octogonz commented on Mar 11, 2020

    @octogonz
    Pete Gonzalez (octogonz)
    on Mar 11, 2020

    Very excited for this to get some attention Sheetal Nandi (@sheetalkamat)! This issue has been open for a lonnnng time.

  18. Sheetal Nandi (sheetalkamat)
    added
    Fix AvailableA PR has been opened for this issue
    and removed
    Needs InvestigationThis issue needs a team member to investigate its status.
    on Mar 13, 2020

  19. sheetalkamat commented on Mar 13, 2020

    @sheetalkamat
    Sheetal Nandi (sheetalkamat)
    on Mar 13, 2020
    Member

    Good news.. i have fix prototype available.. need to polish it and write some tests.. But i will get PR up soon.

  20. Sheetal Nandi (sheetalkamat)
    added a commit that references this issue on Mar 13, 2020

    When the imported module is through node_modules and symlink to folde…

    b259d12
  21. Sheetal Nandi (sheetalkamat)
    closed this as completedin #37387on Mar 16, 2020
  22. Sheetal Nandi (sheetalkamat)
    added a commit that references this issue on Mar 16, 2020

    When the imported module is through node_modules and symlink to fold…

    2458c8a

  23. huntye1 commented on Aug 6, 2021

    @huntye1
    huntye1
    on Aug 6, 2021

    still have this problem...

    Good news.. i have fix prototype available.. need to polish it and write some tests.. But i will get PR up soon.

  24. leohxj commented on Apr 7, 2022

    @leohxj
    Leo Hui (leohxj)
    on Apr 7, 2022

    I set public-hoist-pattern for some phantom modules, but vs code not correctly find the modules or its corresponding type declarations.

    microsoft/rushstack#3324 (comment)

  25. dermicus-miclip commented on Nov 4, 2022

    @dermicus-miclip
    Michael Lippens (dermicus-miclip)
    on Nov 4, 2022

    For those still searching, make sure that you have vscode installed with the WSL plugin. You must be sure that the WSL backend is used!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Fix AvailableA PR has been opened for this issueScenario: Monorepos & Cross-Project ReferencesRelates to composite projects (a.k.a references between "medium sized projects")

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions