Repository navigation
TSC crashes during binding in UWP JS project #34672
Description
TypeScript Version: 3.7.1-rc
Search Terms:
bindSpecialPropertyAssignment
Repro Instructions
In Visual Studio 2017:
- Create a WinJS APP (Universal Windows) project.
- Add a TypeScript JSON Configuration file in project.
- Delete all code in "tsconfig.json" and add code below:
{
"compilerOptions": {
"module": "commonjs",
"allowJs": true,
"outDir": "out",
"jsx": "react"
},
"exclude": [
"node_modules",
"wwwroot",
"out"
],
"compileOnSave": true,
"typingOptions": {
"enableAutoDiscovery": true
}
} - Build project.
Expected behavior:
Build successful.
Actual behavior:
TSC crashes with the following stack:
1> Unknown output: throw e;
1> Unknown output: ^
1> Unknown output: at Object.cast (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.7\tsc.js:1309:25)
1> Unknown output: at bindSpecialPropertyAssignment (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.7\tsc.js:31379:53)
1> Unknown output: at bindWorker (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.7\tsc.js:30946:29)
1> Unknown output: at bind (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.7\tsc.js:30825:13)
1> Unknown output: at bindExpressionStatement (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.7\tsc.js:30033:13)
1> Unknown output: at bindChildrenWorker (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.7\tsc.js:29494:21)
1> Unknown output: at bindChildren (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.7\tsc.js:29415:17)
1> Unknown output: at bind (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.7\tsc.js:30836:21)
1> Unknown output: at C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.7\tsc.js:29421:94
1> Unknown output: at bindEach (C:\Program Files (x86)\Microsoft SDKs\TypeScript\3.7\tsc.js:29437:21)
Activity
DanielRosenwasser commentedon Oct 23, 2019
Any chance you can provide the code that comes out of the box?
uniqueiniquity commentedon Oct 23, 2019
It's also crashing the language service (as one would expect).
Will provide the code in a sec:
uniqueiniquity commentedon Oct 23, 2019
Here's all the .js and .d.ts files included in the project when running with 3.6.
371crash.zip
DanielRosenwasser commentedon Oct 23, 2019
Reduced repro in a JS file:
minestarks commentedon Dec 17, 2019
Wesley Wigham (@weswigham) Ryan Cavanaugh (@RyanCavanaugh) we're still getting hits from this in 3.7.3 in VS. https://devdiv.visualstudio.com/DevDiv/_queries/edit/1041219/?triage=true
weswigham commentedon Dec 17, 2019
Hm, Daniel Rosenwasser (@DanielRosenwasser) 's reduced repro is definitely fixed, and I'm not seeing an editor crash with the repro Ben Lichtman (@uniqueiniquity) linked anymore, at least not with the latest builds of
master. Do we know more?minestarks commentedon Dec 17, 2019
Possibly. What kind of data might help? With bugs from telemetry, we don't have the source code available but we can look at patterns to help narrow down a repro. If you need to collect more context we can look into adding better error reporting for the next iteration. Just need to know what kind of information would help you investigate.
weswigham commentedon Dec 18, 2019
I mean, it's strange, because our check to even attempt a special property bind is
and our two covered cases here are supposed to be
hasDynamicName(node)andisBindableStaticAccessExpression(node.left). All I can think of is some mismatch betweenhasDynamicName(node)andisDynamicName(lhs); but I can't think of any code structure that'd cause such a mismatch to make a repro. Honestly the AST/source ofnodearound the assertion failure would be nice.minestarks commentedon Dec 18, 2019
Any chance this is related to #35730 ? That also has to do with dynamic names in accessors and that was fixed in 3.7.3.
I will follow up on how we can collect contextual information for debugging while keeping in line with privacy guidelines.
weswigham commentedon Dec 18, 2019
? The PR you linked just merged today?
minestarks commentedon Dec 18, 2019
Sorry I have no idea how I ended up pasting that number. I meant to link to #35630 . I was wondering if the bugs may be related since that fix was for a bug that was also occurring in 3.7.3 in property accessors.
minestarks commentedon Jan 22, 2020
Wesley Wigham (@weswigham) any more info you need on this?
weswigham commentedon Feb 7, 2020
Ben Lichtman (@uniqueiniquity) is this still reproducible with the js in the UWP app template? If so, can I just get a copy of the TS+JS in that template? If not, and it's just that we're still getting similar hits in telemetry: ??? Is this still persisting in current telemetry? I could add some slightly more helpful information to the assertion failure.
uniqueiniquity commentedon Feb 7, 2020
Wesley Wigham (@weswigham) Nope, that template is fine in 3.7.4 and in 3.8.1.