Repository navigation
In JS, assertions imported via commonjs have bogus error #38379
Description
Code
// @filename: declares.d.ts
// this is the declaration for 'assert' from @types/node
export function art(value: any, message?: string | Error): asserts value;
// @filename: test.js
const { art } = require('./declares')
let x = 1
art(x)Expected behavior:
No error.
Actual behavior:
Error: "Assertions require every name in the call target to be declared with an explicit type annotation."
There is no error when using ES imports:
// @filename: test2.js
import { art } from './declares'
let x = 1
art(x)
Activity
sandersn commentedon May 6, 2020
Repros since 3.7, when we introduced asserts.
DanielRosenwasser commentedon May 7, 2020
My hot take is that this is a bogus error almost everywhere you could get it...
Raynos commentedon Jun 15, 2020
I ran into this today when updating
@types/nodeand usingrequire('assert')from node core.I fixed this with
Is it possible for the type definition of
requirein TypeScript itself to returnfunction require(module: T): import<T>?sandersn commentedon Jul 8, 2020
The problem is that symbols imported via
requirearen't actually aliases, so they don't get resolved ingetTypeOfDottedName.sandersn commentedon Jul 9, 2020
I prototyped a solution at the branch alias-for-require. It fixes this example, but is woefully incomplete everywhere else. It still needs:
Wesley Wigham (@weswigham) you might be interested in this.