Visitor throws Cannot read property 'kind' of undefined using [email protected] #38558

Activity

1. lissein commented on May 14, 2020

   

   Lissein (lissein)

   on May 14, 2020

   Last edited by lissein

   Contributor

   More actions

   I managed to reduce the reproduction code down to:

   const f = (props: any) => (...args: any) => ''; 
   
   f({
       background: `${1} anything`,
       ...{ test: 1 },
   })``

   The issue is in the es2015 transformer so any target above es2015 will be fine. In fact, the issue is in the object literal visitor when the node contains "es2015 features (eg. template literals, arrow functions, ...)" that need to be transformed. So you can reproduce the same crash with this code using arrow functions:

   const f = (props: any) => (...args: any) => ''; 
   
   f({
       background: (() => 1)(),
       ...{ test: 1 },
   })``

   This code, for instance does not crash because the object literal doesn't have any es2015 features in it.

   const f = (props: any) => (...args: any) => ''; 
   
   f({
       background: 'anything',
       ...{ test: 1 },
   })``

   I'll try to fix this.

   ---

   Until the bug is fixed, Lukas Klusis (@lukaskl) you can use a string instead of a template literal for the background variable or use an external variable to store the template literal outside of the object literal like that:

   export interface ColorProps {
     style?: CSSProperties
   }
   
   const Color = styled(({ style }: ColorProps) => {
     const background = `${1 + 1}`;
     return (
       <div
         style={{
           ...style,
           background,
         }}
       />
     );
   })``

   👍React with 👍1Reacted by Lukas Klusis
2. lukaskl commented on May 14, 2020

   

   Lukas Klusis (lukaskl)

   on May 14, 2020

   Author

   More actions

   Thank you Lissein (@lissein) for investigating this!

   To add another workaround, it is also possible to split this into two definitions, e.g.:

   const ColorUnstyled = ({ style }: ColorProps) => (
     <div
       style={{
         ...style,
         background: `anything`,
       }}
     />
   )
   
   const Color = styled(ColorUnstyled)``

   👍React with 👍1Reacted by Lissein
3. lissein commented on May 14, 2020

   

   Lissein (lissein)

   on May 14, 2020

   Contributor

   More actions

   After more investigations, I confirmed that the code crashing is in the es2015 transformer but the root cause is not in here. The bug is actually in the es2018 transformer.
   Here is an example of code with a target es2017 (< es2018):

   const f = (props: any) => (...args: any) => ''; 
   
   f({
       background: (() => 1)(),
       ...{ test: 1 },
   })``
   
   const a = {
       ...{ test: 1 },
   }

   "use strict";
   const f = (props) => (...args) => '';
   f({
       background: (() => 1)(),
       ...{ test: 1 },
   }) ``;
   const a = Object.assign({ test: 1 });

   As you can see, the second spread is transpiled correctly but the first one isn't.
4. Ryan Cavanaugh (RyanCavanaugh)

   added

   BugA bug in TypeScriptA bug in TypeScript

   on May 14, 2020
5. Ryan Cavanaugh (RyanCavanaugh)

   added this to the TypeScript 3.9 May 2020 Servicing Release milestone on May 14, 2020
6. Ryan Cavanaugh (RyanCavanaugh)

   assigned

   Eli Barzilay (elibarzilay)

   on May 14, 2020
7. Ryan Cavanaugh (RyanCavanaugh)

   modified the milestones: TypeScript 3.9 May 2020 Servicing Release, TypeScript 4.0 on May 14, 2020
8. elibarzilay commented on May 15, 2020

   

   Eli Barzilay (elibarzilay)

   on May 15, 2020

   Contributor

   More actions

   (This is most likely very unrelated to #38383...)
9. Eli Barzilay (elibarzilay)

   added 2 commits that reference this issue on May 15, 2020

   Make `processTaggedTemplateExpression` visit a returned node

   ...

   This issue will close once commit f8d63fb is merged into the 'main' branch.

   f8d63fb

   Make `processTaggedTemplateExpression` visit a returned node

   ...

   This issue will close once commit ea1e0ab is merged into the 'main' branch.

   ea1e0ab
10. Eli Barzilay (elibarzilay)

    closed this as completedin #38596on May 15, 2020
11. Eli Barzilay (elibarzilay)

    added a commit that references this issue on May 15, 2020

    Make `processTaggedTemplateExpression` visit a returned node

    ...

    This issue will close once commit 33c3e9e is merged into the 'main' branch.

    33c3e9e
12. chaselal commented on Jul 21, 2020

    

    chaselal

    on Jul 21, 2020

    Last edited by chaselal

    More actions

    tsc throws the same error for me with TypeScript version 3.9.7:

    Chase@DESKTOP-P21MP39 MINGW64 ~/company/companyWeb/projects/company.Server.Web ((b99b96a0de...))
    $ node_modules/typescript/bin/tsc
    C:\Users\Chase\company\companyWeb\projects\company.Server.Web\node_modules\typescript\lib\tsc.js:82931
                    throw e;
                    ^
    
    TypeError: Cannot read property 'kind' of undefined
        at visitObjectLiteralExpression (C:\Users\Chase\company\companyWeb\projects\company.Server.Web\node_modules\typescript\lib\tsc.js:70631:35)
        at visitJavaScript (C:\Users\Chase\company\companyWeb\projects\company.Server.Web\node_modules\typescript\lib\tsc.js:69611:28)
        at visitor (C:\Users\Chase\company\companyWeb\projects\company.Server.Web\node_modules\typescript\lib\tsc.js:69554:24)
        at visitNode (C:\Users\Chase\company\companyWeb\projects\company.Server.Web\node_modules\typescript\lib\tsc.js:63010:23)
        at Object.visitEachChild (C:\Users\Chase\company\companyWeb\projects\company.Server.Web\node_modules\typescript\lib\tsc.js:63260:45)
        at visitParenthesizedExpression (C:\Users\Chase\company\companyWeb\projects\company.Server.Web\node_modules\typescript\lib\tsc.js:70365:23)
        at visitJavaScript (C:\Users\Chase\company\companyWeb\projects\company.Server.Web\node_modules\typescript\lib\tsc.js:69625:28)
        at visitor (C:\Users\Chase\company\companyWeb\projects\company.Server.Web\node_modules\typescript\lib\tsc.js:69554:24)
        at Object.visitNode (C:\Users\Chase\company\companyWeb\projects\company.Server.Web\node_modules\typescript\lib\tsc.js:63010:23)
        at transformFunctionBody (C:\Users\Chase\company\companyWeb\projects\company.Server.Web\node_modules\typescript\lib\tsc.js:70307:37)
    

    My project is quite large. I don't know which code tsc fails on.

    Edit: This happens when I try to upgrade directly from typescript version 3.7.3 to 3.9.7. Version 3.7.3 works for me.
13. peterj35-dd commented on Aug 11, 2021

    

    Peter Ju (peterj35-dd)

    on Aug 11, 2021

    Last edited by peterj35-dd

    More actions

    Why has this issue been closed, what is the resolution without having to make manual code changes? I'm facing the same issue on 3.9.10, targetting ES5
14. microsoft

    locked as resolved and limited conversation to collaborators on Oct 21, 2025